Skip to content

PolkitDialog: use Gtk.PasswordEntry #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

PolkitDialog: use Gtk.PasswordEntry #91

merged 1 commit into from
Oct 20, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 2, 2025

Fixes #66

It does not show its contents in clear text, does not allow to copy it to the clipboard, and it shows a warning when Caps Lock is engaged. If the underlying platform allows it, GtkPasswordEntry will also place the text in a non-pageable memory area, to avoid it being written out to disk by the operating system.

@danirabbit danirabbit requested a review from a team October 2, 2025 18:50
@danirabbit danirabbit added this to OS 9 Oct 3, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 Oct 3, 2025
ryonakano
ryonakano approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice improvements!

@ryonakano ryonakano merged commit 305a4e5 into main Oct 20, 2025
4 checks passed
@ryonakano ryonakano deleted the danirabbit/passwordentry branch October 20, 2025 14:29
@github-project-automation github-project-automation bot moved this from Needs Review to Done in OS 9 Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

OS 9
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toggle password visibility

3 participants

@danirabbit @ryonakano