Skip to content

PolkitDialog: use Gtk.PasswordEntry #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

PolkitDialog: use Gtk.PasswordEntry #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/PolkitDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class Ag.PolkitDialog : Granite.MessageDialog, PantheonWayland.ExtendedBe
private Gtk.Revealer feedback_revealer;
private Gtk.Label password_label;
private Gtk.Label password_feedback;
private Gtk.Entry password_entry;
private Gtk.PasswordEntry password_entry;
private Gtk.ComboBox idents_combo;

public PolkitDialog (string message, string icon_name, string _cookie,
Expand All @@ -60,12 +60,10 @@ public class Ag.PolkitDialog : Granite.MessageDialog, PantheonWayland.ExtendedBe
primary_text = _("Authentication Required");
secondary_text = message;

password_entry = new Gtk.Entry () {
password_entry = new Gtk.PasswordEntry () {
activates_default = true,
hexpand = true,
input_purpose = PASSWORD,
primary_icon_name = "dialog-password-symbolic",
primary_icon_tooltip_text = _("Password")
show_peek_icon = true
};

password_feedback = new Gtk.Label (null) {
Expand Down Expand Up @@ -219,7 +217,6 @@ public class Ag.PolkitDialog : Granite.MessageDialog, PantheonWayland.ExtendedBe
select_session ();
}

password_entry.secondary_icon_name = "";
feedback_revealer.reveal_child = false;

sensitive = false;
Expand Down Expand Up @@ -274,7 +271,6 @@ public class Ag.PolkitDialog : Granite.MessageDialog, PantheonWayland.ExtendedBe
}

private void on_pk_request (string request, bool echo_on) {
password_entry.visibility = echo_on;
if (!request.has_prefix ("Password:")) {
password_label.label = request;
}
Expand Down Expand Up @@ -303,7 +299,6 @@ public class Ag.PolkitDialog : Granite.MessageDialog, PantheonWayland.ExtendedBe
iterate = shake.done.connect (() => {
if (repeat_count == 4) {
feedback_revealer.reveal_child = true;
password_entry.secondary_icon_name = "dialog-error-symbolic";
password_feedback.label = text;
sensitive = true;
disconnect (iterate);
Expand Down