SettingsSideBar: Fix selection of the correct row #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/fix-row-selection
branch
2 times, most recently
from
34ccaef to
b95a86c
Compare
leolost2605
force-pushed
the
leolost/fix-row-selection
branch
from
b95a86c to
a44823c
Compare
jeremypw
approved these changes
Feb 5, 2025
Contributor
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
The changes make sense and everything related seems to work including the described issue.
Member
|
This is an API break and doesn't work for stack pages that don't have a name. For example this breaks sharing settings |
danirabbit
added a commit
that referenced
this pull request
Feb 6, 2025
This reverts commit 054ab20.
Member
Author
|
Yeah I probably should've put that in the PR description. |
Member
|
Yeah I'm not opposed to the change itself, it just is causing breakage right now. So we should add a new API and deprecate the old one |
lenemter
pushed a commit
that referenced
this pull request
Feb 7, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mix up happening with settingspage title and the name of the visible child in the stack. This would cause e.g. when opening a plug for the first time via a search result the wrong result to show up. Also in further searches the wrong row would be selected. All of this is fixed now.