Clean up onCanSendFeedbackChange - #218
Merged
Merged
Conversation
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 20, 2026 21:29
a1b2b05 to
ac90e9f
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
2 times, most recently
from
July 20, 2026 22:32
2659f2c to
8c22851
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 20, 2026 23:28
8c22851 to
8f93b67
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 21, 2026 10:51
8f93b67 to
5d97543
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 21, 2026 12:29
5d97543 to
00c9094
Compare
renal128
marked this pull request as draft
July 21, 2026 22:59
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 21, 2026 23:02
00c9094 to
78569e7
Compare
renal128
marked this pull request as ready for review
July 21, 2026 23:05
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 22, 2026 13:21
78569e7 to
d1fa826
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 22, 2026 15:34
d1fa826 to
3aa7052
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 23, 2026 09:06
3aa7052 to
cc87613
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
July 23, 2026 09:10
cc87613 to
218b1b0
Compare
This was referenced Jul 25, 2026
jacksonh
approved these changes
Aug 3, 2026
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 15:47
218b1b0 to
c5660fe
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 16:38
c5660fe to
67f823b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 67f823b. Configure here.
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 18:33
67f823b to
3df5dcf
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 18:44
1c1d7d5 to
cf47a8e
Compare
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 18:49
cf47a8e to
933b9a2
Compare
Feedback is available whenever the conversation is connected, so consumers can derive availability directly from state. Co-authored-by: Cursor <cursoragent@cursor.com>
renal128
force-pushed
the
remove-feedback-availability-callback
branch
from
August 4, 2026 19:11
933b9a2 to
b7c7b74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Per-message feedback can be sent at any time as long as the conversation is connected. But historically it was implemented via some complex logic on the client, so that feedback was only allowed on the last message if that message doesn't have feedback yet - that's purely a client-side limitation that we don't need.
Changes:
onCanSendFeedbackChangeand its event-tracking stateTest plan
swift testNote
Medium Risk
Public API removal breaks apps that relied on
onCanSendFeedbackChange; behavior change may allow feedback on older messages while connected, which is intentional but affects UI assumptions.Overview
Removes client-side feedback gating so apps no longer get
onCanSendFeedbackChangeor internal tracking (lastAgentEventId,lastFeedbackSubmittedEventId). Feedback is allowed for anyeventIdwhile the session is connected;sendFeedbackstill throws when not connected.Breaking:
ConversationCallbacks.onCanSendFeedbackChangeis removed from the public API. UI should enable thumbs up/down based onclient.state.isConnected(or equivalent) instead of SDK-driven toggles on agent response, interruption, disconnect, and after submit.Docs and tests are updated:
Usage.mdshowsConversationClient+guard client.state.isConnected, and unit tests assert published feedback payloads instead of callback-driven availability.Reviewed by Cursor Bugbot for commit b7c7b74. Bugbot is set up for automated code reviews on this repo. Configure here.