Skip to content

Clean up onCanSendFeedbackChange - #218

Merged
renal128 merged 1 commit into
nextfrom
remove-feedback-availability-callback
Aug 4, 2026
Merged

Clean up onCanSendFeedbackChange#218
renal128 merged 1 commit into
nextfrom
remove-feedback-availability-callback

Conversation

@renal128

@renal128 renal128 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Per-message feedback can be sent at any time as long as the conversation is connected. But historically it was implemented via some complex logic on the client, so that feedback was only allowed on the last message if that message doesn't have feedback yet - that's purely a client-side limitation that we don't need.

Changes:

  • remove onCanSendFeedbackChange and its event-tracking state
  • make connected conversation state the sole feedback availability signal
  • update feedback documentation and coverage for connected/disconnected behavior

Test plan

  • swift test

Note

Medium Risk
Public API removal breaks apps that relied on onCanSendFeedbackChange; behavior change may allow feedback on older messages while connected, which is intentional but affects UI assumptions.

Overview
Removes client-side feedback gating so apps no longer get onCanSendFeedbackChange or internal tracking (lastAgentEventId, lastFeedbackSubmittedEventId). Feedback is allowed for any eventId while the session is connected; sendFeedback still throws when not connected.

Breaking: ConversationCallbacks.onCanSendFeedbackChange is removed from the public API. UI should enable thumbs up/down based on client.state.isConnected (or equivalent) instead of SDK-driven toggles on agent response, interruption, disconnect, and after submit.

Docs and tests are updated: Usage.md shows ConversationClient + guard client.state.isConnected, and unit tests assert published feedback payloads instead of callback-driven availability.

Reviewed by Cursor Bugbot for commit b7c7b74. Bugbot is set up for automated code reviews on this repo. Configure here.

@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from a1b2b05 to ac90e9f Compare July 20, 2026 21:29
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch 2 times, most recently from 2659f2c to 8c22851 Compare July 20, 2026 22:32
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 8c22851 to 8f93b67 Compare July 20, 2026 23:28
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 8f93b67 to 5d97543 Compare July 21, 2026 10:51
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 5d97543 to 00c9094 Compare July 21, 2026 12:29
@renal128
renal128 marked this pull request as draft July 21, 2026 22:59
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 00c9094 to 78569e7 Compare July 21, 2026 23:02
@renal128
renal128 marked this pull request as ready for review July 21, 2026 23:05
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 78569e7 to d1fa826 Compare July 22, 2026 13:21
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from d1fa826 to 3aa7052 Compare July 22, 2026 15:34
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 3aa7052 to cc87613 Compare July 23, 2026 09:06
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from cc87613 to 218b1b0 Compare July 23, 2026 09:10
@renal128 renal128 changed the title Remove feedback availability callback Clean up onCanSendFeedbackChange Jul 26, 2026
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 218b1b0 to c5660fe Compare August 4, 2026 15:47
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from c5660fe to 67f823b Compare August 4, 2026 16:38

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 67f823b. Configure here.

Comment thread Sources/ElevenLabs/Public/Conversation/ConversationCallbacks.swift
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 67f823b to 3df5dcf Compare August 4, 2026 18:33
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 1c1d7d5 to cf47a8e Compare August 4, 2026 18:44
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from cf47a8e to 933b9a2 Compare August 4, 2026 18:49
Base automatically changed from simplify-client-tool-results to next August 4, 2026 19:11
Feedback is available whenever the conversation is connected, so consumers can derive availability directly from state.

Co-authored-by: Cursor <cursoragent@cursor.com>
@renal128
renal128 force-pushed the remove-feedback-availability-callback branch from 933b9a2 to b7c7b74 Compare August 4, 2026 19:11
@renal128
renal128 merged commit f2cbaff into next Aug 4, 2026
2 checks passed
@renal128
renal128 deleted the remove-feedback-availability-callback branch August 4, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants