feat: add frontpage banner for vietnamese#2155
Conversation
WalkthroughThis update includes two main changes: the project artifact version in the Maven dependency tree is incremented from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant CSS
User->>Browser: Loads page with data-content-language="vie"
Browser->>CSS: Applies styles from styles.css
CSS-->>Browser: Sets #index-banner background to banner-vn.png if language is "vie"
Possibly related PRs
Suggested reviewers
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -1,4 +1,4 @@ | |||
| ai.elimu:webapp:war:2.5.98-SNAPSHOT | |||
| ai.elimu:webapp:war:2.5.99-SNAPSHOT | |||
There was a problem hiding this comment.
@jo-elimu Do we want to use a snapshot release here?
There was a problem hiding this comment.
@tuancoltech Good question. The challenge with this file is that it is only generated when the application is launched (during localhost development). So it also often happens that code changes are made without this file being updated. It's not a perfect setup, but I think it's better than not keeping track of the dependency tree at all.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
=========================================
Coverage 15.18% 15.18%
Complexity 388 388
=========================================
Files 232 232
Lines 6131 6131
Branches 707 707
=========================================
Hits 931 931
Misses 5150 5150
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add frontpage background image for
vie.elimu.aiIssue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check.If this PR contains files with format violations, run
mvn spotless:applyto fix them.