Skip to content

feat: add frontpage banner for vietnamese#2155

Merged
jo-elimu merged 2 commits intomainfrom
2122-banner-vietnamese
Apr 21, 2025
Merged

feat: add frontpage banner for vietnamese#2155
jo-elimu merged 2 commits intomainfrom
2122-banner-vietnamese

Conversation

@jo-elimu
Copy link
Copy Markdown
Member

@jo-elimu jo-elimu commented Apr 21, 2025

Add frontpage background image for vie.elimu.ai

Issue Number

Purpose

Technical Details

Testing Instructions

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu requested a review from tuancoltech April 21, 2025 01:53
@jo-elimu jo-elimu self-assigned this Apr 21, 2025
@jo-elimu jo-elimu requested a review from a team as a code owner April 21, 2025 01:53
@jo-elimu jo-elimu linked an issue Apr 21, 2025 that may be closed by this pull request
@jo-elimu jo-elimu requested review from AshishBagdane, nya-elimu and tomaszsmy and removed request for a team April 21, 2025 01:53
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 21, 2025

Walkthrough

This update includes two main changes: the project artifact version in the Maven dependency tree is incremented from 2.5.98-SNAPSHOT to 2.5.99-SNAPSHOT, and a new CSS rule is introduced to display a specific background image for the #index-banner element when the page's data-content-language attribute is set to Vietnamese ("vie"). No other dependencies, styles, or public interfaces are modified.

Changes

File(s) Change Summary
pom-dependency-tree.txt Updated the main project artifact version from 2.5.98-SNAPSHOT to 2.5.99-SNAPSHOT.
src/main/webapp/static/css/styles.css Added a CSS rule to set a Vietnamese-specific banner background image for #index-banner.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Browser
    participant CSS

    User->>Browser: Loads page with data-content-language="vie"
    Browser->>CSS: Applies styles from styles.css
    CSS-->>Browser: Sets #index-banner background to banner-vn.png if language is "vie"
Loading

Possibly related PRs

  • chore(deps): model 2.0.83 #2038: Updates the pom-dependency-tree.txt file to bump the main project artifact version, similar to this PR's version update.
  • Add support for Vietnamese #2131: Adds Vietnamese language support through JSP resource blocks and deployment updates, which is related to the new Vietnamese banner styling in this PR.

Suggested reviewers

  • vrudas
  • SnehaHS65
  • Souvik-Cyclic

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eeac9b4 and 4ad8225.

⛔ Files ignored due to path filters (1)
  • src/main/webapp/static/img/banner-vn.png is excluded by !**/*.png, !**/*.png
📒 Files selected for processing (2)
  • pom-dependency-tree.txt (1 hunks)
  • src/main/webapp/static/css/styles.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: test_ui_localhost
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (windows-latest, 21)
🔇 Additional comments (2)
pom-dependency-tree.txt (1)

1-1: Version bump to 2.5.99-SNAPSHOT is correct
This update aligns with the new snapshot release for the frontend enhancement.

src/main/webapp/static/css/styles.css (1)

34-36: Add Vietnamese frontpage banner rule
The new CSS rule follows the existing pattern for language‑specific banners. Ensure that banner-vn.png is present under static/img so the asset loads correctly.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment thread pom-dependency-tree.txt
@@ -1,4 +1,4 @@
ai.elimu:webapp:war:2.5.98-SNAPSHOT
ai.elimu:webapp:war:2.5.99-SNAPSHOT
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jo-elimu Do we want to use a snapshot release here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuancoltech Good question. The challenge with this file is that it is only generated when the application is launched (during localhost development). So it also often happens that code changes are made without this file being updated. It's not a perfect setup, but I think it's better than not keeping track of the dependency tree at all.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.18%. Comparing base (81178d5) to head (4ad8225).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2155   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
  Complexity      388      388           
=========================================
  Files           232      232           
  Lines          6131     6131           
  Branches        707      707           
=========================================
  Hits            931      931           
  Misses         5150     5150           
  Partials         50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jo-elimu jo-elimu merged commit 5a38b07 into main Apr 21, 2025
10 checks passed
@jo-elimu jo-elimu deleted the 2122-banner-vietnamese branch April 21, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new language: Vietnamese

2 participants