Skip to content

feat: add frontpage banner for vietnamese #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jo-elimu merged 2 commits into from
Apr 21, 2025
Merged

feat: add frontpage banner for vietnamese #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2737d9
feat: add frontpage banner for vietnamese
jo-elimu Apr 21, 2025
4ad8225
feat: add frontpage banner for vietnamese
jo-elimu Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom-dependency-tree.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ai.elimu:webapp:war:2.5.98-SNAPSHOT
ai.elimu:webapp:war:2.5.99-SNAPSHOT
Copy link
Copy Markdown
Member

@tuancoltech tuancoltech Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jo-elimu Do we want to use a snapshot release here?

Copy link
Copy Markdown
Member Author

@jo-elimu jo-elimu Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuancoltech Good question. The challenge with this file is that it is only generated when the application is launched (during localhost development). So it also often happens that code changes are made without this file being updated. It's not a perfect setup, but I think it's better than not keeping track of the dependency tree at all.

+- com.github.elimu-ai:model:jar:model-2.0.97:compile
| \- com.google.code.gson:gson:jar:2.13.0:compile
| \- com.google.errorprone:error_prone_annotations:jar:2.37.0:compile
Expand Down
3 changes: 3 additions & 0 deletions src/main/webapp/static/css/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ html[data-content-language="tgl"] #index-banner {
html[data-content-language="tha"] #index-banner {
background-image: url(../../static/img/banner-th.jpg);
}
html[data-content-language="vie"] #index-banner {
background-image: url(../../static/img/banner-vn.png);
}

.container > .section {
min-height: 400px;
Expand Down
Binary file added src/main/webapp/static/img/banner-vn.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.