Skip to content

fix(release): restore desktop release inputs#7812

Closed
lalalune wants to merge 1 commit into
developfrom
shaw/release-followup-platform-fixes
Closed

fix(release): restore desktop release inputs#7812
lalalune wants to merge 1 commit into
developfrom
shaw/release-followup-platform-fixes

Conversation

@lalalune
Copy link
Copy Markdown
Member

@lalalune lalalune commented May 19, 2026

Summary

  • add the desktop release regression inventory and manual checklist required by the release validator
  • generate @elizaos/ui CSS-string modules before desktop Vite builds so ignored generated files exist in fresh release checkouts

Validation

  • bun run test:regression-matrix:release
  • bun run --cwd packages/ui generate:css-strings
  • git diff --check --cached
  • actionlint .github/workflows/release-all.yml .github/workflows/release-electrobun.yml .github/workflows/build-linux-iso.yml

Release context

  • v2.0.1 release lanes failed because the desktop checklist docs were missing and Linux ISO could not resolve packages/ui/src/components/voice-pill/voice-pill.css.ts in a fresh checkout.
  • NPM publishing is still separately blocked by npm returning E404 while publishing @elizaos/agent@2.0.1; this PR does not change npm credentials or registry ownership.

Greptile Summary

This PR bundles several independent fixes targeting the v2.0.1 release lane: it expands DB-schema stubs in multiple test mocks (so schema-exhaustiveness checks pass), refactors the capability-router audit script from long if-else chains to lookup tables, adds elizaos as the first entry in DEFAULT_AGENTS, updates spawn-agent test expectations, adds a (userMessage || input.authenticatedUser) provisioning guard in the onboarding flow, and pins onnxruntime-web@1.26.0 in the agent package.

  • Schema mock expansion (agent-gateway-router, message-router, phone-gateway-devices tests): adds all missing table entries to mock.module("../../db/schemas") stubs so tests compile against the current schema shape.
  • Audit script refactor (audit-capability-router-live-ci.ts): replaces repetitive if-else dispatch in getCheckContent/getCheckSourcePath with checkContentReaders and checkSourcePaths lookup tables, and converts order-independent lookahead regexes to bounded sequential patterns.
  • Onboarding provisioning gate (onboarding-chat.ts): ensureElizaAppProvisioning is now skipped when neither a user message nor an authenticated-user context is present, preventing spurious provisioning on passive status-check calls.

Confidence Score: 4/5

Safe to merge with minor follow-up: the regex ordering change in the audit script could silently produce false audit failures if source-file term ordering doesn't match the new patterns, and onnxruntime-web is misplaced as a devDependency in a Node.js package.

The regex change from order-independent lookaheads to order-dependent sequential patterns in the audit script is a semantic shift that could cause valid checks to fail if the underlying test files declare the verified terms in a different order than assumed. It would not break production behaviour, but it could mask regressions by producing false audit failures. The onnxruntime-web dependency placement is also unusual and could pull WASM binaries into the agent package unnecessarily.

packages/scripts/audit-capability-router-live-ci.ts (regex ordering) and packages/agent/package.json (onnxruntime-web placement).

Important Files Changed

Filename Overview
packages/scripts/audit-capability-router-live-ci.ts Refactors getCheckContent/getCheckSourcePath from if-else chains to lookup tables (good DRY improvement), extracts CheckContentOptions type, and replaces order-independent lookahead regexes with order-dependent sequential patterns — changing matching semantics.
packages/agent/package.json Adds onnxruntime-web@1.26.0 as a devDependency; this browser/WASM ONNX runtime is unusual in a Node.js agent package and likely belongs in a UI or app-core package.
packages/cloud-shared/src/lib/services/eliza-app/onboarding-chat.ts Adds a (userMessage
packages/cloud-shared/src/lib/services/eliza-app/provisioning.test.ts Adds Date.now() cache-busting to the dynamic import() path to force Bun to bypass the module cache and load fresh mocks on each test run.
plugins/plugin-agent-orchestrator/src/services/acp-service.ts Adds "elizaos" to the front of DEFAULT_AGENTS, making it the first-preference fallback agent type for new ACP sessions.
plugins/plugin-agent-orchestrator/tests/unit/spawn-agent.test.ts Updates spawn-agent tests to expect an acknowledgement text and callback invocation; consistent with the updated implementation.
packages/cloud-shared/src/lib/services/agent-gateway-router.test.ts Expands the mock.module("../../db/schemas") stub with all missing table entries to satisfy schema exhaustiveness checks.
packages/cloud-api/webhooks/bluebubbles/route.test.ts Extracts a registeredGatewayDevice() factory to reduce fixture duplication and narrows skippedReason to its explicit string-literal union.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["runOnboardingChat(input)"] --> B{requiresLogin?}
    B -- yes --> C[skip provisioning]
    B -- no --> D{userMessage OR authenticatedUser?}
    D -- no --> E["getElizaAppProvisioningStatus(orgId)"]
    D -- yes --> F{preferredNameCaptured?}
    F -- no --> E
    F -- yes --> G["ensureElizaAppProvisioning(userId, organizationId)"]
    G --> H[session.agentId = provisioning.agentId]
    E --> H
Loading

Reviews (18): Last reviewed commit: "fix(release): restore desktop release in..." | Re-trigger Greptile

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 896d3d3c-a8a5-4926-a76c-522541cf9abc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shaw/release-followup-platform-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

Comment thread packages/app-core/scripts/desktop-build.mjs
@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from ba8accb to 2a45e0b Compare May 19, 2026 21:17
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 3 times, most recently from 690d29e to 8b38b5a Compare May 19, 2026 22:03
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 8b38b5a to 3e0cc49 Compare May 19, 2026 22:18
@github-actions github-actions Bot added the core label May 19, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 3e0cc49 to 1ef990b Compare May 19, 2026 22:29
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 1ef990b to 46fa190 Compare May 19, 2026 22:40
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 46fa190 to a0d234d Compare May 19, 2026 22:51
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from a0d234d to ba56ccc Compare May 19, 2026 22:56
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from ba56ccc to e000b12 Compare May 19, 2026 22:59
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from e000b12 to f55bab4 Compare May 19, 2026 23:09
@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 2 times, most recently from 817515d to fcfcfa8 Compare May 19, 2026 23:15
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from fcfcfa8 to ef5bf7a Compare May 19, 2026 23:23
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 19, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 3 times, most recently from b8e5300 to 96dbf83 Compare May 20, 2026 02:01
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 2 times, most recently from 677c495 to 6f0592e Compare May 20, 2026 02:20
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 6f0592e to f95a7af Compare May 20, 2026 02:36
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from f95a7af to 84adb3c Compare May 20, 2026 02:49
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

lalalune pushed a commit that referenced this pull request May 20, 2026
Cherry-pick of f95a7af minus the scope-sprawl bits:
- Dropped unjustified onnxruntime-web dep + bun.lock churn
- Dropped DEFAULT_AGENTS "elizaos" addition (unrelated behavior change)
- Dropped spawn-agent.test.ts changes (assertions contradict impl which
  intentionally returns empty text and skips cb — the orchestrator hook
  owns the user-visible flow)
- Took develop's version for conflicting test files
  (route.test.ts, onboarding-chat.ts, provisioning.test.ts,
  audit-capability-router-live-ci.ts) where develop has moved on
- Kept: docs refresh, ensureUiGeneratedAssets() before vite build,
  pluginEntrySchema.launch field, remaining test mock cleanups

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch 2 times, most recently from 51627c3 to 6e52fa0 Compare May 20, 2026 03:00
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 1s —— View job


I'll analyze this and get back to you.

@lalalune lalalune force-pushed the shaw/release-followup-platform-fixes branch from 6e52fa0 to 675d1cb Compare May 20, 2026 03:07
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@lalalune
Copy link
Copy Markdown
Member Author

Merged into develop in 03deafa (PR branch consolidated and rebased onto develop with post-merge fixes; see develop log for details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant