fix(release): restore desktop release inputs#7812
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
ba8accb to
2a45e0b
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
690d29e to
8b38b5a
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
8b38b5a to
3e0cc49
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
3e0cc49 to
1ef990b
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
1ef990b to
46fa190
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
46fa190 to
a0d234d
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
a0d234d to
ba56ccc
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
ba56ccc to
e000b12
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
e000b12 to
f55bab4
Compare
817515d to
fcfcfa8
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
fcfcfa8 to
ef5bf7a
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
b8e5300 to
96dbf83
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
677c495 to
6f0592e
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
6f0592e to
f95a7af
Compare
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
f95a7af to
84adb3c
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
Cherry-pick of f95a7af minus the scope-sprawl bits: - Dropped unjustified onnxruntime-web dep + bun.lock churn - Dropped DEFAULT_AGENTS "elizaos" addition (unrelated behavior change) - Dropped spawn-agent.test.ts changes (assertions contradict impl which intentionally returns empty text and skips cb — the orchestrator hook owns the user-visible flow) - Took develop's version for conflicting test files (route.test.ts, onboarding-chat.ts, provisioning.test.ts, audit-capability-router-live-ci.ts) where develop has moved on - Kept: docs refresh, ensureUiGeneratedAssets() before vite build, pluginEntrySchema.launch field, remaining test mock cleanups Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
51627c3 to
6e52fa0
Compare
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
6e52fa0 to
675d1cb
Compare
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
|
Merged into develop in 03deafa (PR branch consolidated and rebased onto develop with post-merge fixes; see develop log for details). |
Summary
Validation
Release context
Greptile Summary
This PR bundles several independent fixes targeting the v2.0.1 release lane: it expands DB-schema stubs in multiple test mocks (so schema-exhaustiveness checks pass), refactors the capability-router audit script from long if-else chains to lookup tables, adds
elizaosas the first entry inDEFAULT_AGENTS, updates spawn-agent test expectations, adds a(userMessage || input.authenticatedUser)provisioning guard in the onboarding flow, and pinsonnxruntime-web@1.26.0in the agent package.agent-gateway-router,message-router,phone-gateway-devicestests): adds all missing table entries tomock.module("../../db/schemas")stubs so tests compile against the current schema shape.audit-capability-router-live-ci.ts): replaces repetitive if-else dispatch ingetCheckContent/getCheckSourcePathwithcheckContentReadersandcheckSourcePathslookup tables, and converts order-independent lookahead regexes to bounded sequential patterns.onboarding-chat.ts):ensureElizaAppProvisioningis now skipped when neither a user message nor an authenticated-user context is present, preventing spurious provisioning on passive status-check calls.Confidence Score: 4/5
Safe to merge with minor follow-up: the regex ordering change in the audit script could silently produce false audit failures if source-file term ordering doesn't match the new patterns, and onnxruntime-web is misplaced as a devDependency in a Node.js package.
The regex change from order-independent lookaheads to order-dependent sequential patterns in the audit script is a semantic shift that could cause valid checks to fail if the underlying test files declare the verified terms in a different order than assumed. It would not break production behaviour, but it could mask regressions by producing false audit failures. The onnxruntime-web dependency placement is also unusual and could pull WASM binaries into the agent package unnecessarily.
packages/scripts/audit-capability-router-live-ci.ts (regex ordering) and packages/agent/package.json (onnxruntime-web placement).
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["runOnboardingChat(input)"] --> B{requiresLogin?} B -- yes --> C[skip provisioning] B -- no --> D{userMessage OR authenticatedUser?} D -- no --> E["getElizaAppProvisioningStatus(orgId)"] D -- yes --> F{preferredNameCaptured?} F -- no --> E F -- yes --> G["ensureElizaAppProvisioning(userId, organizationId)"] G --> H[session.agentId = provisioning.agentId] E --> HReviews (18): Last reviewed commit: "fix(release): restore desktop release in..." | Re-trigger Greptile