perf: avoid match-data allocation in lsp--file-process-event#5016
Merged
jcs090218 merged 1 commit intoemacs-lsp:masterfrom Mar 15, 2026
Merged
perf: avoid match-data allocation in lsp--file-process-event#5016jcs090218 merged 1 commit intoemacs-lsp:masterfrom
jcs090218 merged 1 commit intoemacs-lsp:masterfrom
Conversation
Previously, string-match was allocating match-data on every iteration of the inner watcher loop; string-match-p avoids this. Separately, defer glob-pattern lookup to the cache-miss path.
jcs090218
approved these changes
Mar 15, 2026
Member
|
Thank you! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, string-match was allocating match-data on every iteration of the inner watcher loop; string-match-p avoids this.
Separately, defer glob-pattern lookup to the cache-miss path.