Skip to content

perf: avoid match-data allocation in lsp--file-process-event #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcs090218 merged 1 commit into from
Mar 15, 2026
+6 −7
Merged

perf: avoid match-data allocation in lsp--file-process-event #5016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions lsp-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3933,18 +3933,17 @@ disappearing, unset all the variables related to it."
"workspace/didChangeWatchedFiles")
(cl-loop for fs-watcher across (lsp:did-change-watched-files-registration-options-watchers
(lsp--registered-capability-options capability))
thereis (let ((glob-pattern (lsp:file-system-watcher-glob-pattern fs-watcher))
(kind? (lsp:file-system-watcher-kind? fs-watcher))
(cached-regexp (lsp-get fs-watcher :_cachedRegexp)))
thereis (let ((kind? (lsp:file-system-watcher-kind? fs-watcher)))
(when (or (null kind?)
(> (logand kind? watch-bit) 0))
(let ((regexes (or cached-regexp
(let ((regexp (lsp-glob-to-regexps glob-pattern)))
(let ((regexes (or (lsp-get fs-watcher :_cachedRegexp)
(let ((regexp (lsp-glob-to-regexps
(lsp:file-system-watcher-glob-pattern fs-watcher))))
(lsp-put fs-watcher :_cachedRegexp regexp)
regexp))))
(cl-loop for re in regexes
thereis (or (string-match re changed-file)
(string-match re rel-changed-file)))))))))
thereis (or (string-match-p re changed-file)
(string-match-p re rel-changed-file)))))))))
(with-lsp-workspace workspace
(lsp-notify
"workspace/didChangeWatchedFiles"
Expand Down
Loading