File attachment integration branch#1804
Merged
fractalwrench merged 20 commits intomainfrom Jan 29, 2025
Merged
Conversation
c2285df to
a2705ab
Compare
9371cf1 to
b780037
Compare
a2705ab to
03333fa
Compare
b780037 to
bec56c6
Compare
3567a47 to
de1fe3b
Compare
bec56c6 to
35f775e
Compare
0be25c8 to
19bc55d
Compare
06f92e1 to
a61c5c5
Compare
a61c5c5 to
9f2662c
Compare
19bc55d to
ea9d7fd
Compare
9f2662c to
f1ed6ad
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
f1ed6ad to
01286eb
Compare
Implement user hosted file attachments
Refactors and test code for attachment work
Add integration tests for file attachments
Remove size parameter from user hosted log messages
Support embrace hosted attachments
Tweak log attachment implementation after manual testing
Add log message attachment example
priettt
reviewed
Jan 29, 2025
| val parts = mutableListOf<FormPart>() | ||
|
|
||
| reader.use { | ||
| while (true) { |
Contributor
There was a problem hiding this comment.
nit: maybe you can use something like generateSequence { it.nextPart() }, and map the result to a FormPart. The while(true) looks weird, though it does the same 😅
priettt
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Adds an API for logging a message with a file attachment. This API is not fully functional yet and only creates a log message in the existing way, without any attachment.
Testing
Added skeleton of integration tests.