Skip to content

File attachment integration branch #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fractalwrench merged 20 commits into from
Jan 29, 2025

remove attachment example temporarily

ad53a57
Select commit
Loading
Failed to load commit list.
Merged

File attachment integration branch #1804

remove attachment example temporarily
ad53a57
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

85.38% (+0.04%) compared to 3a22455

View this Pull Request on Codecov

85.38% (+0.04%) compared to 3a22455

Details

Codecov Report

Attention: Patch coverage is 89.77273% with 18 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (3a22455) to head (ad53a57).

Files with missing lines Patch % Lines
...mbracesdk/internal/api/delegate/LogsApiDelegate.kt 81.08% 2 Missing and 5 partials ⚠️
...nal/resurrection/PayloadResurrectionServiceImpl.kt 0.00% 0 Missing and 2 partials ⚠️
...elivery/execution/OkHttpRequestExecutionService.kt 95.00% 0 Missing and 2 partials ⚠️
...nal/delivery/storage/CachedLogEnvelopeStoreImpl.kt 0.00% 0 Missing and 2 partials ⚠️
...roid/embracesdk/internal/logs/EmbraceLogService.kt 75.00% 0 Missing and 1 partial ⚠️
...embracesdk/internal/logs/attachments/Attachment.kt 94.11% 1 Missing ⚠️
...dk/internal/session/orchestrator/V1PayloadStore.kt 0.00% 1 Missing ⚠️
...ndroid/embracesdk/internal/delivery/PayloadType.kt 93.33% 0 Missing and 1 partial ⚠️
.../java/io/embrace/android/embracesdk/EmbraceImpl.kt 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
+ Coverage   85.34%   85.38%   +0.04%     
==========================================
  Files         473      474       +1     
  Lines       11079    11158      +79     
  Branches     1660     1680      +20     
==========================================
+ Hits         9455     9527      +72     
+ Misses        888      882       -6     
- Partials      736      749      +13
Files with missing lines Coverage Δ
...oid/embracesdk/internal/injection/LogModuleImpl.kt 92.10% <100.00%> (+0.67%) ⬆️
...ace/android/embracesdk/internal/logs/LogService.kt 100.00% <100.00%> (ø)
...k/internal/logs/attachments/AttachmentErrorCode.kt 100.00% <ø> (ø)
...sdk/internal/logs/attachments/AttachmentService.kt 100.00% <100.00%> (ø)
...sdk/internal/opentelemetry/EmbraceAttributeKeys.kt 100.00% <100.00%> (ø)
...dk/internal/session/orchestrator/V2PayloadStore.kt 95.12% <100.00%> (+0.67%) ⬆️
...cesdk/internal/delivery/StoredTelemetryMetadata.kt 79.31% <100.00%> (-0.69%) ⬇️
...racesdk/internal/delivery/SupportedEnvelopeType.kt 100.00% <100.00%> (ø)
...esdk/internal/delivery/intake/IntakeServiceImpl.kt 100.00% <100.00%> (ø)
...sdk/internal/delivery/storage/AttachmentStorage.kt 100.00% <100.00%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

View more details on Codecov