Consolidate and disambiguate version checking for load traces capability detection#1833
Merged
bidetofevil merged 1 commit intomainfrom Jan 22, 2025
Merged
Consolidate and disambiguate version checking for load traces capability detection#1833bidetofevil merged 1 commit intomainfrom
bidetofevil merged 1 commit intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
==========================================
- Coverage 85.52% 85.51% -0.01%
==========================================
Files 473 473
Lines 11068 11069 +1
Branches 1653 1654 +1
==========================================
Hits 9466 9466
Misses 866 866
- Partials 736 737 +1
|
9424bbd to
fc6d9ef
Compare
fractalwrench
approved these changes
Jan 22, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Split up and consolidate the logic to check whether the current API version fires pre and post lifecycle events and whether or not we we try to instrument rendering for UI Load events.
This is so that in a later PR, we can disable the rendering events without affecting everything else.
Testing
Existing tests pass