Skip to content

Use resume end for UI load end for now if possible#1835

Merged
bidetofevil merged 1 commit intomainfrom
hho/add-resume-span
Jan 22, 2025
Merged

Use resume end for UI load end for now if possible#1835
bidetofevil merged 1 commit intomainfrom
hho/add-resume-span

Conversation

@bidetofevil
Copy link
Contributor

@bidetofevil bidetofevil commented Jan 21, 2025

Goal

End UI load traces on postResume for API versions that support it. This will allow us to track the duration for all onResume callbacks.

Testing

Existing tests passed after adjustment

Copy link
Contributor Author

bidetofevil commented Jan 21, 2025

@bidetofevil bidetofevil marked this pull request as ready for review January 21, 2025 21:47
@bidetofevil bidetofevil requested a review from a team as a code owner January 21, 2025 21:47
Copy link
Contributor Author

bidetofevil commented Jan 22, 2025

Merge activity

  • Jan 22, 4:04 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 4:20 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 4:29 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/disable-render-event to graphite-base/1835 January 22, 2025 21:05
@bidetofevil bidetofevil changed the base branch from graphite-base/1835 to main January 22, 2025 21:18
@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit f29e9ef into main Jan 22, 2025
6 checks passed
@bidetofevil bidetofevil deleted the hho/add-resume-span branch January 22, 2025 21:29
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (20bc609) to head (78259ab).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 45.83% 12 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   85.25%   85.33%   +0.08%     
==========================================
  Files         473      473              
  Lines       11069    11076       +7     
  Branches     1654     1657       +3     
==========================================
+ Hits         9437     9452      +15     
+ Misses        894      887       -7     
+ Partials      738      737       -1     
Files with missing lines Coverage Δ
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 81.75% <45.83%> (+6.36%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants