Use resume end for UI load end for now if possible#1835
Merged
bidetofevil merged 1 commit intomainfrom Jan 22, 2025
Merged
Conversation
This was referenced Jan 21, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fractalwrench
approved these changes
Jan 22, 2025
Contributor
Author
43fa7e9 to
78259ab
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
+ Coverage 85.25% 85.33% +0.08%
==========================================
Files 473 473
Lines 11069 11076 +7
Branches 1654 1657 +3
==========================================
+ Hits 9437 9452 +15
+ Misses 894 887 -7
+ Partials 738 737 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
End UI load traces on
postResumefor API versions that support it. This will allow us to track the duration for all onResume callbacks.Testing
Existing tests passed after adjustment