Skip to content

Add support for SpanLinks#2053

Merged
bidetofevil merged 1 commit intomainfrom
hho/spanlinks
Mar 21, 2025
Merged

Add support for SpanLinks#2053
bidetofevil merged 1 commit intomainfrom
hho/spanlinks

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 20, 2025

Goal

Add basic support for SpanLinks. A couple of things still have to be finalized:

  • Payload shape
  • Limits

Thought I'd get this in review first and made the approach changes after

Testing

Unit and integration tests added

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil marked this pull request as ready for review March 20, 2025 22:12
@bidetofevil bidetofevil requested review from a team, fnewberg and fractalwrench as code owners March 20, 2025 22:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (52fa657) to head (1ef05a6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 83.78% 3 Missing and 3 partials ⚠️
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 33.33% 3 Missing and 1 partial ⚠️
.../android/embracesdk/internal/payload/SpanMapper.kt 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   85.28%   85.24%   -0.05%     
==========================================
  Files         466      468       +2     
  Lines       10525    10570      +45     
  Branches     1559     1565       +6     
==========================================
+ Hits         8976     9010      +34     
- Misses        871      878       +7     
- Partials      678      682       +4     
Files with missing lines Coverage Δ
...ndroid/embracesdk/internal/gating/SpanSanitizer.kt 75.00% <100.00%> (+0.71%) ⬆️
...droid/embracesdk/internal/opentelemetry/EmbSpan.kt 96.66% <100.00%> (+0.23%) ⬆️
...droid/embracesdk/internal/spans/EmbraceLinkData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanData.kt 90.00% <100.00%> (+0.52%) ⬆️
...e/android/embracesdk/internal/spans/SpanDataExt.kt 100.00% <100.00%> (ø)
...nal/config/instrumented/schema/OtelLimitsConfig.kt 100.00% <100.00%> (ø)
...mbrace/android/embracesdk/internal/payload/Link.kt 100.00% <100.00%> (ø)
...mbrace/android/embracesdk/internal/payload/Span.kt 100.00% <100.00%> (ø)
.../android/embracesdk/internal/payload/SpanMapper.kt 55.31% <40.00%> (-1.50%) ⬇️
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 61.53% <33.33%> (-24.18%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending discussion with folks on other SDKs about what the payload & behavior of limits should look like

Copy link
Copy Markdown
Contributor Author

Pablo is good with the structure, so I'm going to merge it down and change it later if folks disagree with aspects.

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Mar 21, 2025

Merge activity

  • Mar 21, 10:19 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 21, 10:19 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 21, 10:38 AM EDT: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 9825312 into main Mar 21, 2025
11 checks passed
@bidetofevil bidetofevil deleted the hho/spanlinks branch March 21, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants