Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
122b209 to
18e3911
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
- Coverage 85.28% 85.24% -0.05%
==========================================
Files 466 468 +2
Lines 10525 10570 +45
Branches 1559 1565 +6
==========================================
+ Hits 8976 9010 +34
- Misses 871 878 +7
- Partials 678 682 +4
🚀 New features to boost your workflow:
|
fractalwrench
approved these changes
Mar 21, 2025
Member
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM pending discussion with folks on other SDKs about what the payload & behavior of limits should look like
Contributor
Author
|
Pablo is good with the structure, so I'm going to merge it down and change it later if folks disagree with aspects. |
Contributor
Author
18e3911 to
1ef05a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Add basic support for SpanLinks. A couple of things still have to be finalized:
Thought I'd get this in review first and made the approach changes after
Testing
Unit and integration tests added