Skip to content

Add support for SpanLinks #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bidetofevil merged 1 commit into from
Mar 21, 2025

Add support for SpanLinks

1ef05a6
Select commit
Loading
Failed to load commit list.
Merged

Add support for SpanLinks #2053

Add support for SpanLinks
1ef05a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 21, 2025 in 1s

85.24% (-0.05%) compared to 52fa657

View this Pull Request on Codecov

85.24% (-0.05%) compared to 52fa657

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (52fa657) to head (1ef05a6).

Files with missing lines Patch % Lines
...droid/embracesdk/internal/spans/EmbraceSpanImpl.kt 83.78% 3 Missing and 3 partials ⚠️
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 33.33% 3 Missing and 1 partial ⚠️
.../android/embracesdk/internal/payload/SpanMapper.kt 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   85.28%   85.24%   -0.05%     
==========================================
  Files         466      468       +2     
  Lines       10525    10570      +45     
  Branches     1559     1565       +6     
==========================================
+ Hits         8976     9010      +34     
- Misses        871      878       +7     
- Partials      678      682       +4
Files with missing lines Coverage Δ
...ndroid/embracesdk/internal/gating/SpanSanitizer.kt 75.00% <100.00%> (+0.71%) ⬆️
...droid/embracesdk/internal/opentelemetry/EmbSpan.kt 96.66% <100.00%> (+0.23%) ⬆️
...droid/embracesdk/internal/spans/EmbraceLinkData.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanData.kt 90.00% <100.00%> (+0.52%) ⬆️
...e/android/embracesdk/internal/spans/SpanDataExt.kt 100.00% <100.00%> (ø)
...nal/config/instrumented/schema/OtelLimitsConfig.kt 100.00% <100.00%> (ø)
...mbrace/android/embracesdk/internal/payload/Link.kt 100.00% <100.00%> (ø)
...mbrace/android/embracesdk/internal/payload/Span.kt 100.00% <100.00%> (ø)
.../android/embracesdk/internal/payload/SpanMapper.kt 55.31% <40.00%> (-1.50%) ⬇️
...io/embrace/android/embracesdk/spans/EmbraceSpan.kt 61.53% <33.33%> (-24.18%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov