Skip to content

Remove thread sampler installer internal API for Unity#2208

Merged
bidetofevil merged 1 commit intomainfrom
hho/remove-sampler-installer
May 21, 2025
Merged

Remove thread sampler installer internal API for Unity#2208
bidetofevil merged 1 commit intomainfrom
hho/remove-sampler-installer

Conversation

@bidetofevil
Copy link
Contributor

@bidetofevil bidetofevil commented May 15, 2025

Goal

Remove API that is no logger needed as Unity thread sampling is no longer supported

@bidetofevil bidetofevil requested a review from a team as a code owner May 15, 2025 18:09
@bidetofevil bidetofevil requested a review from priettt May 15, 2025 18:09
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (7cfb135) to head (5a96216).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2208   +/-   ##
=======================================
  Coverage   85.61%   85.62%           
=======================================
  Files         465      465           
  Lines       10381    10379    -2     
  Branches     1522     1522           
=======================================
- Hits         8888     8887    -1     
+ Misses        836      835    -1     
  Partials      657      657           
Files with missing lines Coverage Δ
...nternal/api/delegate/UnityInternalInterfaceImpl.kt 45.09% <ø> (+0.86%) ⬆️
...nternal/api/delegate/NoopUnityInternalInterface.kt 42.85% <ø> (-7.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if you've confirmed with the Unity guild they are ok with this change

Copy link
Contributor Author

Yup. They're removing it on their end too.

Copy link
Contributor Author

bidetofevil commented May 21, 2025

Merge activity

  • May 21, 6:09 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 21, 6:09 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 21, 6:26 PM UTC: @bidetofevil merged this pull request with Graphite.

@bidetofevil bidetofevil force-pushed the hho/remove-sampler-installer branch from d686c32 to 5a96216 Compare May 21, 2025 18:09
@bidetofevil bidetofevil merged commit d2581cf into main May 21, 2025
10 checks passed
@bidetofevil bidetofevil deleted the hho/remove-sampler-installer branch May 21, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants