Skip to content

Remove thread sampler installer internal API for Unity #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bidetofevil merged 1 commit into from
May 21, 2025
Merged

Remove thread sampler installer internal API for Unity #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...in/java/io/embrace/android/embracesdk/internal/api/delegate/UnityInternalInterfaceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,4 @@ internal class UnityInternalInterfaceImpl(
)
)
}

@Deprecated("Obsolete, will be removed in a future release.")
override fun installUnityThreadSampler() {
}
}
6 changes: 0 additions & 6 deletions ...rnal-api/src/main/kotlin/io/embrace/android/embracesdk/internal/UnityInternalInterface.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,4 @@ interface UnityInternalInterface :
statusCode: Int,
traceId: String?,
)

/**
* @suppress
*/
@Deprecated("Obsolete, will be removed in a future release.")
fun installUnityThreadSampler()
}
4 changes: 0 additions & 4 deletions .../kotlin/io/embrace/android/embracesdk/internal/api/delegate/NoopUnityInternalInterface.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,4 @@ internal class NoopUnityInternalInterface(
traceId: String?,
) {
}

@Deprecated("Obsolete, will be removed in a future release.")
override fun installUnityThreadSampler() {
}
}
2 changes: 0 additions & 2 deletions .../test/kotlin/io/embrace/android/embracesdk/internal/api/NoopUnityInternalInterfaceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ internal class NoopUnityInternalInterfaceTest {
)
}

@Suppress("DEPRECATION")
@Test
fun `check no errors thrown when invoked`() {
impl.setUnityMetaData("unityVersion", "buildGuid", "unitySdkVersion")
Expand All @@ -44,6 +43,5 @@ internal class NoopUnityInternalInterfaceTest {
200,
"traceId"
)
impl.installUnityThreadSampler()
}
}
Loading