Fix a bug where disabling the sdk might cause a background exception#2226
Merged
Fix a bug where disabling the sdk might cause a background exception#2226
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
- Coverage 85.62% 85.58% -0.04%
==========================================
Files 467 467
Lines 10398 10400 +2
Branches 1531 1532 +1
==========================================
- Hits 8903 8901 -2
- Misses 836 838 +2
- Partials 659 661 +2
🚀 New features to boost your workflow:
|
bidetofevil
approved these changes
Jun 4, 2025
Contributor
bidetofevil
left a comment
There was a problem hiding this comment.
This should fix this issue. That said, I would move this entire block after stop(). If the SDK isn't started when this is called, we shouldn't trigger a delete, which requires the SDK to have been started.
Either make the purge not require the SDK to have started before or don't invoke it.
f534092 to
5cf3065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
runCatchingdoesn't handle exceptions happening on another thread. This PR fixes that issue.