Skip to content

Fix a bug where disabling the sdk might cause a background exception #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
priettt merged 1 commit into from
Jun 5, 2025
Merged

Fix a bug where disabling the sdk might cause a background exception #2226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import android.annotation.SuppressLint
import android.app.Application
import android.content.Context
import android.util.Log
import io.embrace.android.embracesdk.core.BuildConfig
import io.embrace.android.embracesdk.internal.EmbraceInternalApi
import io.embrace.android.embracesdk.internal.EmbraceInternalInterface
Expand Down Expand Up @@ -246,13 +247,13 @@
if (sdkCallChecker.started.get()) {
bootstrapper.openTelemetryModule.otelSdkConfig.disableDataExport()
stop()
}

// delete any persisted data
runCatching {
Executors.newSingleThreadExecutor().execute {
StorageLocation.values().map { it.asFile(bootstrapper.coreModule.context, logger).value }.forEach {
it.deleteRecursively()
runCatching {
StorageLocation.values().map { it.asFile(bootstrapper.coreModule.context, logger).value }.forEach {
it.deleteRecursively()
}
}.onFailure { exception ->
Log.e("[Embrace]", "An error occurred while trying to disable Embrace SDK.", exception)

Check warning on line 256 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.kt

View check run for this annotation

Codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/EmbraceImpl.kt#L256 

Added line #L256 was not covered by tests
}
}
}
Expand Down
Loading