Skip to content

Add featutre flag for navigation state#3180

Open
bidetofevil wants to merge 1 commit intohho/misc-race-fixesfrom
hho/nav-state-feature-flag
Open

Add featutre flag for navigation state#3180
bidetofevil wants to merge 1 commit intohho/misc-race-fixesfrom
hho/nav-state-feature-flag

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 31, 2026

Goal

Add remote feature flag to control the navigation state capture feature. The default is true because it should be on if the state feature is on

@bidetofevil bidetofevil force-pushed the hho/nav-state-feature-flag branch from d59d0cb to 58ce8e9 Compare March 31, 2026 16:15
@bidetofevil bidetofevil marked this pull request as ready for review March 31, 2026 16:16
@bidetofevil bidetofevil requested a review from a team as a code owner March 31, 2026 16:16
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team March 31, 2026 16:16
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.09%. Comparing base (55e4641) to head (58ce8e9).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           hho/misc-race-fixes    #3180      +/-   ##
=======================================================
- Coverage                78.10%   78.09%   -0.02%     
=======================================================
  Files                      556      556              
  Lines                    11982    11985       +3     
  Branches                  1788     1789       +1     
=======================================================
+ Hits                      9359     9360       +1     
  Misses                    1912     1912              
- Partials                   711      713       +2     
Files with missing lines Coverage Δ
...nal/config/behavior/AutoDataCaptureBehaviorImpl.kt 90.47% <100.00%> (+0.47%) ⬆️
.../embracesdk/internal/config/remote/RemoteConfig.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants