Keep in-memory cache consistent when file deletion fails

[bidetofevil]

Goal

Remove file from in-memory cache regardless of whether the delete was successful. This addresses an inconsistency that was bubbled up through the PayloadStorageServiceImpl where when delete calls faile at the FileSystemService level, it did not remove the payload from the in-memory cache, leading to the PayloadStorageService thinking that it was still there.

[bidetofevil]

• Track state for activity to activity navigation #3181
• Add featutre flag for navigation state #3180
• Fix misc race conditions found #3174
• Delete the NetworkStatus concept #3173
• Migrate SchedulingServiceImpl to ConnectivityStatus #3172
• Streamline post-intake cleanup #3167
• Delete payloads that fail to be resurrected #3166
• Treat non-429 HTTP failure codes as transient #3165
• Add additional exceptions to list that triggers connect block #3164
• Keep in-memory cache consistent when file deletion fails #3163 👈 (View in Graphite)
• Deliver payload types in order that they were received #3160 : 1 other dependent PR (#3161 )
• Block sending of non-crash payloads on resurrection #3159
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.00%. Comparing base (b637ff0) to head (3477481).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
+ Coverage   77.89%   78.00%   +0.10%     
==========================================
  Files         558      558              
  Lines       11931    11973      +42     
  Branches     1782     1792      +10     
==========================================
+ Hits         9294     9339      +45     
+ Misses       1927     1924       -3     
  Partials      710      710              

Files with missing lines	Coverage Δ
...nternal/delivery/storage/FileStorageServiceImpl.kt	78.43% <100.00%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fractalwrench]

LGTM

[bidetofevil]

Merge activity

• Mar 30, 5:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Mar 30, 5:24 PM UTC: Graphite rebased this pull request as part of a merge.
• Mar 30, 5:25 PM UTC: @bidetofevil merged this pull request with Graphite.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 3477481.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None