Use Android-specific log limits instead of shared component#727
Merged
nelsitoPuglisi merged 2 commits intomainfrom Mar 10, 2026
Merged
Use Android-specific log limits instead of shared component#727nelsitoPuglisi merged 2 commits intomainfrom
nelsitoPuglisi merged 2 commits intomainfrom
Conversation
The shared/log-limit.md cannot serve both platforms correctly because Android and iOS SDKs have different values for properties per log (100 vs 10) and property value length (1024 vs 256). Android docs now use inline values matching the actual Android SDK constants. Also removes the log message max length line since that value is controlled by remote config and the SDK default (128) does not reflect the production behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary - Markdown Lint |
Summary - Link Checker
|
fractalwrench
approved these changes
Mar 10, 2026
Member
fractalwrench
left a comment
fractalwrench
left a comment
There was a problem hiding this comment.
LGTM pending CI
@ArielDemarco do we have plans to alter this limit on iOS so that it matches Android? (Or vice versa)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/log-limit.mdimport in Android docs with inline values matching the actual Android SDKshared/log-limit.md(values match iOS SDK)docs/android/integration-advanced/log-message-api.mddocs/android/legacy-integration/log-message-api.mdAndroid SDK sources:
MAX_PROPERTY_COUNT = 100inLogServiceImpl.ktMAX_PROPERTY_KEY_LENGTH = 128inLogServiceImpl.ktMAX_PROPERTY_VALUE_LENGTH = 1024inLogServiceImpl.ktTest plan
🤖 Generated with Claude Code