Merged
Conversation
emichael
changed the title
emichael
force-pushed
the
improvement/event-sealed-interface
branch
from
db10ab0 to
afc5e22
Compare
wilcoxjay
approved these changes
Mar 22, 2026
Collaborator
wilcoxjay
left a comment
wilcoxjay
left a comment
There was a problem hiding this comment.
lgtm. couple of minor questions in the inline feedback
Java has proper sum types now. We should use them. This requires language level 21.
emichael
force-pushed
the
improvement/event-sealed-interface
branch
from
afc5e22 to
6177b86
Compare
Collaborator
|
|
Owner
Author
|
Thanks, @wilcoxjay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java has proper sum types now. We should use them. This requires language level 21.