Skip to content

Movable props codegen#374

Merged
KodrAus merged 16 commits into
mainfrom
feat/props-move
Jun 10, 2026
Merged

Movable props codegen#374
KodrAus merged 16 commits into
mainfrom
feat/props-move

Conversation

@KodrAus

@KodrAus KodrAus commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

For #360

This PR introduces a new style of props! codegen that will let us move out of individual properties. This not only helps with 2024 edition changes to scoping, it also makes props! much more useful in other contexts, like as evt_props on #[span], because they can now be properly owned.

It's a fairly substantial change. This new method generates a lot more code than the old way, so it'll need some thorough testing to make sure it doesn't bloat compile times too much.

@KodrAus KodrAus mentioned this pull request Jun 8, 2026
5 tasks
@KodrAus

KodrAus commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

The props module could do with some documentation, since it’s the most complex piece of codegen we have.

The book and docs also need updating to make more use of props! now instead of other types now that we can actually use it.

@KodrAus KodrAus marked this pull request as ready for review June 10, 2026 19:35
@KodrAus KodrAus merged commit 515afdb into main Jun 10, 2026
75 of 77 checks passed
@KodrAus KodrAus deleted the feat/props-move branch June 10, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant