Movable props codegen#374
Merged
Merged
Conversation
Contributor
Author
|
The The book and docs also need updating to make more use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #360
This PR introduces a new style of
props!codegen that will let us move out of individual properties. This not only helps with 2024 edition changes to scoping, it also makesprops!much more useful in other contexts, like asevt_propson#[span], because they can now be properly owned.It's a fairly substantial change. This new method generates a lot more code than the old way, so it'll need some thorough testing to make sure it doesn't bloat compile times too much.