-
Notifications
You must be signed in to change notification settings - Fork 60
Open
Description
Describe the feature you want
The openarm_hardware package has support for parsing a can_fd parameter, which defaults to true.
openarm_ros2/openarm_hardware/src/v10_simple_hardware.cpp
Lines 52 to 61 in 39dc03e
| // Parse CAN-FD enable (default: true for V10) | |
| it = info.hardware_parameters.find("can_fd"); | |
| if (it == info.hardware_parameters.end()) { | |
| can_fd_ = true; // Default to true for V10 | |
| } else { | |
| // Handle both "true"/"True" and "false"/"False" | |
| std::string value = it->second; | |
| std::transform(value.begin(), value.end(), value.begin(), ::tolower); | |
| can_fd_ = (value == "true"); | |
| } |
However, none of the launch scripts actually accept and pass along a can_fd argument. Therefore, users who are using CAN-2.0 instead of CAN-FD are unable to use the provided launch scripts without modification.
An additional can_fd argument should be added to all of the existing launch scripts, and passed along appropriately.
def generate_launch_description(): def generate_launch_description(): def generate_launch_description():
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels