Skip to content

Add can_fd argument to bringup launch arguments #65

@FrostyFridge

Description

@FrostyFridge

Describe the feature you want

The openarm_hardware package has support for parsing a can_fd parameter, which defaults to true.

// Parse CAN-FD enable (default: true for V10)
it = info.hardware_parameters.find("can_fd");
if (it == info.hardware_parameters.end()) {
can_fd_ = true; // Default to true for V10
} else {
// Handle both "true"/"True" and "false"/"False"
std::string value = it->second;
std::transform(value.begin(), value.end(), value.begin(), ::tolower);
can_fd_ = (value == "true");
}

However, none of the launch scripts actually accept and pass along a can_fd argument. Therefore, users who are using CAN-2.0 instead of CAN-FD are unable to use the provided launch scripts without modification.

An additional can_fd argument should be added to all of the existing launch scripts, and passed along appropriately.

Metadata

Metadata

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions