fix: clarify QR code instructions for first-time Yivi users#198
Closed
dobby-coder[bot] wants to merge 1 commit into
Closed
fix: clarify QR code instructions for first-time Yivi users#198dobby-coder[bot] wants to merge 1 commit into
dobby-coder[bot] wants to merge 1 commit into
Conversation
QR code instructions previously gave little context, leaving first-time users unsure what to do. Make the instruction text explicit about Yivi being a separate app on the user's phone, surface the existing 'What is Yivi?' help toggle on the encrypt-flow QR popups, and add a description under the fallback decrypt QR. Closes #162
This was referenced May 9, 2026
Contributor
Author
|
Superseded by #203 (consolidation per encryption4all/dobby#53). Closing to keep the queue tidy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds context to the QR code prompts so first-time users understand they need to scan with the Yivi app on their phone (per issue #162).
filesharing.sign.scanQR(encrypt-flow popup) andfilesharing.decryptpanel.irmaInstructionQr(download page) in EN and NL: now explicitly say "verify your identity by scanning this QR code with the free Yivi app on your phone".HelpToggle(already used on the download page) on the encrypt-flow QR popups (desktop popover + mobile bottom sheet).Decrypt.svelteQR header so the legacy fallback also explains what to scan with.Decrypt→Decrypt with Yivion the download header for the QR variant.No JS/component logic changes; only locale text and one extra collapsed help toggle.
Test plan
npm run check(svelte-check) — 0 errors / 0 warningsnpm run build— clean static buildnpx prettier --checkon touched files — formatted/download/...and confirm the new instruction renders in EN and NLReviewer quickstart:
Closes #162