Set up verification of executables on build #627 #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alansemenov
force-pushed
the
issue-627
branch
from
624fad1 to
9ef2a81
Compare
rymsha
reviewed
Nov 6, 2025
| console.log(`Skipping verification for ${platform} ${arch}`); | ||
| process.exit(0); | ||
| } | ||
| if (platform === 'linux' && env['NODE_ARCH'] === 'arm64') { |
Contributor
There was a problem hiding this comment.
only for linux? so on mac it is different?
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| arch: [x64, arm64] |
Contributor
There was a problem hiding this comment.
Suggested change
| arch: [x64, arm64] | |
| arch: [x64, arm64] | |
| exclude: | |
| - os: windows-latest | |
| arch: arm64 |
| */ | ||
| let thisArch = arch; | ||
| if (env['NODE_ARCH']) { | ||
| if (platform === 'win32' && env['NODE_ARCH'] === 'arm64') { |
Contributor
There was a problem hiding this comment.
this magic is not needed if verification matrix excludes arm windows binary
| with: | ||
| args: --clean --snapshot --skip=snapcraft | ||
|
|
||
| - name: Upload the binaries |
Contributor
There was a problem hiding this comment.
this will bloat github actions with large files - very quickly isn't it s that goreleaser already uploads binaries somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.