fix system library error messages #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgn
force-pushed
the
fix-system-errors
branch
from
2e96d27 to
bc51d65
Compare
previously, we'd log a lot of "unknown" error messages. this should fix that. Signed-off-by: Daniel Grimm <[email protected]>
dgn
force-pushed
the
fix-system-errors
branch
from
bc51d65 to
dbd6bd8
Compare
jwendell
approved these changes
Dec 16, 2025
Member
jwendell
left a comment
jwendell
left a comment
There was a problem hiding this comment.
LGTM, but I'll let the expert (@tedjpoole) to chime in.
@dgn BTW, were we supposed to expect changes in envoy tests? I mean all passed but I thought that, with this change, we'd need to revert some of the changes we made in Envoy due to the differences in error strings...
tedjpoole
requested changes
Dec 17, 2025
Contributor
tedjpoole
left a comment
tedjpoole
left a comment
There was a problem hiding this comment.
All good thanks, except some minor niggles. The only real functional change is ERR_reason_error_string() should return "unknown error" rather than a NULL if the reason code is unknown.
| // Handle system library errors like BoringSSL does | ||
| // For system errors, return strerror(errno) like BoringSSL does | ||
| if (ERR_GET_LIB(packed_error) == ERR_LIB_SYS) { | ||
| uint32_t reason = ERR_GET_REASON(packed_error); |
Contributor
There was a problem hiding this comment.
Suggested change
| uint32_t reason = ERR_GET_REASON(packed_error); | |
| uint32_t reason = ossl_ERR_GET_REASON(packed_error); |
| extern "C" const char *ERR_lib_error_string(uint32_t packed_error) { | ||
| // Handle system library errors like BoringSSL does | ||
| // OpenSSL 3.x returns NULL for system errors, but BoringSSL returns "system library" | ||
| if (ERR_GET_LIB(packed_error) == ERR_LIB_SYS) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (ERR_GET_LIB(packed_error) == ERR_LIB_SYS) { | |
| if (ossl_ERR_SYSTEM_ERROR(packed_error)) { |
| extern "C" const char *ERR_reason_error_string(uint32_t packed_error) { | ||
| // Handle system library errors like BoringSSL does | ||
| // For system errors, return strerror(errno) like BoringSSL does | ||
| if (ERR_GET_LIB(packed_error) == ERR_LIB_SYS) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (ERR_GET_LIB(packed_error) == ERR_LIB_SYS) { | |
| if (ossl_ERR_SYSTEM_ERROR(packed_error)) { |
| if (reason > 0 && reason < 256) { | ||
| return strerror(reason); | ||
| } | ||
| return NULL; |
Contributor
There was a problem hiding this comment.
Suggested change
| return NULL; | |
| return "unknown error"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: previously, we'd log a lot of "unknown" error messages. this should fix that.
Additional Description:
Risk Level: low
Testing: included
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]