Update utils.py - Fixed save_checkpoint with scheduler set to None #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrima
reviewed
Apr 16, 2024
| torch.nn.utils.clip_grad_norm_(model.parameters(), extra_args.grad_clip) | ||
| opt.step() | ||
| scheduler.step() | ||
| if scheduler != None: |
There was a problem hiding this comment.
nit: if scheduler is not None
(otherwise LGTM)
There was a problem hiding this comment.
hello, this kind of fix was already proposed in the soap branch,
but we didn't change the sparse.py
thanks for the reminder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
save_checkpointraised an error if scheduler was set to None. This is fixed by setting the scheduler state_dict to None in case the scheduler is not set.