Skip to content

Update utils.py - Fixed save_checkpoint with scheduler set to None #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update utils.py - Fixed save_checkpoint with scheduler set to None #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ee4d71
Update utils.py - Fixed save checkpoint with scheduler set to None
peacefulotter Nov 13, 2023
c015add
Update base.py - Fixed scheduler set to None causes error on schedule…
peacefulotter Nov 13, 2023
c4b9ae8
Update sparse.py - same for sparse.py
peacefulotter Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/optim/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def train_base(model, opt, data, scheduler, iterations, acc_steps, batch_size, s
if extra_args.grad_clip != 0.0:
torch.nn.utils.clip_grad_norm_(model.parameters(), extra_args.grad_clip)
opt.step()
scheduler.step()
if scheduler != None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if scheduler is not None

(otherwise LGTM)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, this kind of fix was already proposed in the soap branch,
but we didn't change the sparse.py

thanks for the reminder)

scheduler.step()
opt.zero_grad(set_to_none=True)
itr += 1

Expand Down
3 changes: 2 additions & 1 deletion src/optim/sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ def train_sparse(model, opt, data, scheduler, iterations, acc_steps, batch_size,
substep += 1

opt.step()
scheduler.step()
if scheduler != None:
scheduler.step()
opt.zero_grad(set_to_none=True)
itr += 1

Expand Down
2 changes: 1 addition & 1 deletion src/optim/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def save_checkpoint(distributed_backend, model, opt, scheduler, itr, ckpt_path,
checkpoint = dict({
'model': distributed_backend.get_raw_model(model).state_dict(),
'optimizer': opt.state_dict(),
'scheduler': scheduler.state_dict(),
'scheduler': scheduler.state_dict() if scheduler != None else None,
'itr': itr,
}, **extra_args)

Expand Down