fix(open): linux error spawning new obsidian process

[benelan]

The ObsidianOpen command failed to open the Obsidian app on Linux if it wasn't already running. After some troubleshooting I determined it is something related to the async module.

Nothing jumped out at me in the plenary job initialization code, but using vim.fn.jobstart(), vim.system(), and vim.uv.spawn() all work. I went with jobstart for backwards compatibility. Let me know if I need to make any other changes, or feel free to adopt this patch however you see fit. Thanks for the great plugin!

Fix #319

[benelan]

I can also only make this change for Linux, if you'd prefer.

  if this_os == util.OSType.Linux then
    vim.fn.jobstart(cmd .. " " .. vim.fn.shellescape(table.concat(args, " ")), { detach = true })
  else
    run_job(cmd, args)
  end

[epwalsh]

@benelan I wonder if it has to do with running in a shell env vs no shell. I think the plenary Job runs without a shell, but vim.fn.jobstart would run in the shell when you pass the command as a string, instead of a list 🤔

[epwalsh]

Hey @benelan, thanks for this!

[epwalsh]

Apparently nvim recommends using vim.system() from Lua instead of vim.fn.jobstart() (see :help jobstart). I'm not entirely sure why but I guess I'd rather follow that recommendation then not.

Also would be good to report errors like run_job() will.

[benelan]

Yeah I checked and unfortunately vim.system() isn't available in v0.9, so I used vim.fn.jobstart() for backwards compatibility. Should I throw a conditional in there to check the nvim version and use vim.system() if it is available?

I'll add in some error reporting either way.

[epwalsh]

Huh, okay in that case let's stick with vim.fn.jobstart. It looks like you can pass a callback there to capture stderr.

[benelan]

@benelan I wonder if it has to do with running in a shell env vs no shell. I think the plenary Job runs without a shell, but vim.fn.jobstart would run in the shell when you pass the command as a string, instead of a list 🤔

Hmm yeah that's possible. I'll experiment with passing a list to jobstart to see if that breaks it or not.

[benelan]

Alright, I added the logging! Opening obsidian with xdg-open writes to stderr even if the process doesn't fail. I confirmed this outside of neovim as well:

$ xdg-open "obsidian://open?vault=notes&file=monorepos.md" 2>&1 >/dev/null

[104469:0126/132841.090072:ERROR:node_bindings.cc(300)] Most NODE_OPTIONs are not supported in packaged apps. See documentation for more details.

(obsidian:104469): Gtk-WARNING **: 13:28:41.206: Theme parsing error: gtk.css:6691:68: Invalid name of pseudo-class
[104469:0126/132841.419062:ERROR:nss_util.cc(357)] After loading Root Certs, loaded==false: NSS error code: -8018

I used on_exit instead and log if the code isn't 0.

I also tested passing a list to jobstart and it still worked. Here is the vim command for reference:

:exe jobstart(["xdg-open", "obsidian://open?vault=notes&file=monorepos.md"], {"detach": v:true})

[epwalsh]

Awesome! Looks good. Just one more minor request and then we can get this merged!

[benelan]

Done, thanks for the review!

[epwalsh]

LGTM!