PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss' - #1782
Conversation
Updates user-facing strings in the settings page, admin notices, AJAX error messages, site health info, and frontend highlighter to use the current "Dismiss" terminology instead of the legacy "Ignore" wording. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAcross five files, the PR replaces user-facing "ignore/ignored" terminology with "dismiss/dismissed". Changes affect the Black Friday admin notice copy, four ChangesIgnore → Dismiss terminology rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the terminology in the Accessibility Checker plugin, replacing variations of 'ignore' with 'dismiss' across admin notices, AJAX handlers, settings, and frontend scripts. The review feedback points out several grammatical issues introduced by this direct replacement, suggesting the use of the noun forms 'dismissal' or 'dismissals' instead of 'dismiss' or 'dismisses' in phrases like 'dismissal logs', 'No dismissal data to return', and 'Dismissals DB Table Count' to ensure natural and correct English phrasing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| $message = '<div class="edac_black_friday_notice notice notice-info is-dismissible">'; | ||
| $message .= '<p><strong>' . esc_html__( '🎉 Black Friday special! 🎉', 'accessibility-checker' ) . '</strong><br />'; | ||
| $message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, ignore logs, and more.', 'accessibility-checker' ) . '<br />'; | ||
| $message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, dismiss logs, and more.', 'accessibility-checker' ) . '<br />'; |
There was a problem hiding this comment.
The phrase 'dismiss logs' is grammatically awkward. Since 'dismiss' is a verb, using the noun form 'dismissal' (i.e., 'dismissal logs') is more grammatically correct and natural in English.
$message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, dismissal logs, and more.', 'accessibility-checker' ) . '<br />';|
|
||
| if ( ! $first_id || ! $valid_table ) { | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) ); | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) ); |
There was a problem hiding this comment.
The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.
wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );| $batch_object = $wpdb->get_var( $wpdb->prepare( 'SELECT object FROM %i WHERE id = %d', $valid_table, $first_id ) ); | ||
| if ( ! $batch_object ) { | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) ); | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) ); |
There was a problem hiding this comment.
The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.
wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );|
|
||
| if ( empty( $affected_post_ids ) ) { | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) ); | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) ); |
There was a problem hiding this comment.
The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.
wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );|
|
||
| if ( ! $data ) { | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) ); | ||
| wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) ); |
There was a problem hiding this comment.
The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.
wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );| ], | ||
| 'ignores_db_table_count' => [ | ||
| 'label' => __( 'Ignores DB Table Count', 'accessibility-checker' ), | ||
| 'label' => __( 'Dismisses DB Table Count', 'accessibility-checker' ), |
There was a problem hiding this comment.
The phrase 'Dismisses DB Table Count' is grammatically incorrect because 'Dismisses' is a verb form. The plural noun form 'Dismissals' (i.e., 'Dismissals DB Table Count') should be used instead to match the original 'Ignores DB Table Count'.
'label' => __( 'Dismissals DB Table Count', 'accessibility-checker' ),![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ee77c55e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| add_settings_field( | ||
| 'edacp_ignore_user_roles', | ||
| __( 'Ignore Permissions', 'accessibility-checker' ), | ||
| __( 'Dismiss Permissions', 'accessibility-checker' ), |
There was a problem hiding this comment.
When a bundled non-English locale is active, this renamed msgid (and the other renamed strings in this commit) is no longer translatable because the checked-in catalogs were not regenerated: languages/accessibility-checker.pot/.po still contain the old Ignore Permissions, No ignore data to return, Ignored, and %d Ignored entries, and the frontend-highlighter JSON still lacks the new Dismissed/%d Dismissed keys. Since WordPress looks up translations by the exact English msgid, these labels fall back to English after this change; please update the POT/PO/MO/JSON artifacts with the source changes.
Useful? React with 👍 / 👎.
Use the noun form "dismissal" instead of the verb "dismiss"/"dismisses" where grammatically required, per Gemini Code Assist review feedback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Addressed the Gemini Code Assist grammar feedback in e068cef — switched to the noun form "dismissal"/"dismissals" where "dismiss"/"dismisses" was grammatically wrong:
Re the Codex comment on regenerating POT/PO/MO/JSON catalogs: this repo regenerates |
2 participants
Summary
develop(PRO-1039 scope item: "all other files and components where 'Ignore' terminology appears").includes/options-page.php— settings field label and descriptionsadmin/class-admin-notices.php— Black Friday promo notice copyadmin/class-ajax.php— AJAX error message (4 occurrences)admin/site-health/class-pro.php— Site Health info labelssrc/frontendHighlighterApp/index.js— highlighter badge label and summary count textTest plan
php -lon all changed PHP filesnode --checkon the changed JS fileignore_global,ignore_user_roles), which are out of scope per Linear discussionCloses PRO-1039
🤖 Generated with Claude Code
Summary by CodeRabbit