Skip to content

PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss' #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveJonesDev merged 2 commits into from
Jun 22, 2026
Merged

PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss' #1782

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee77c5
PRO-1039: Replace remaining 'Ignore' terminology with 'Dismiss'
SteveJonesDev Jun 22, 2026
e068cef
Fix grammar in dismiss terminology per code review
SteveJonesDev Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion admin/class-admin-notices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public function edac_get_black_friday_message() {
// Construct the promotional message.
$message = '<div class="edac_black_friday_notice notice notice-info is-dismissible">';
$message .= '<p><strong>' . esc_html__( '🎉 Black Friday special! 🎉', 'accessibility-checker' ) . '</strong><br />';
$message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, ignore logs, and more.', 'accessibility-checker' ) . '<br />';
$message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, dismiss logs, and more.', 'accessibility-checker' ) . '<br />';

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'dismiss logs' is grammatically awkward. Since 'dismiss' is a verb, using the noun form 'dismissal' (i.e., 'dismissal logs') is more grammatically correct and natural in English.

        $message .= esc_html__( 'Upgrade to a paid version of Accessibility Checker from November 24th to December 3rd and get 30% off! Full site scanning, site-wide open issues report, dismissal logs, and more.', 'accessibility-checker' ) . '<br />';

$message .= '<a class="button button-primary" href="' . esc_url( edac_link_wrapper( 'https://my.equalizedigital.com/support/pre-sale-questions/', 'admin-notice', 'BlackFriday25-presale', false ) ) . '">' . esc_html__( 'Ask a Pre-Sale Question', 'accessibility-checker' ) . '</a> ';
$message .= '<a class="button button-primary" href="' . esc_url( edac_link_wrapper( 'https://equalizedigital.com/accessibility-checker/pricing/', 'admin-notice', 'BlackFriday25-pricing', false ) ) . '">' . esc_html__( 'Upgrade Now', 'accessibility-checker' ) . '</a></p>';
$message .= '</div>';
Expand Down
8 changes: 4 additions & 4 deletions admin/class-ajax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ function ( $value ) {
$valid_table = edac_get_valid_table_name( $table_name );

if ( ! $first_id || ! $valid_table ) {
wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) );
wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) );

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.

            wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );

}

if ( isset( $_REQUEST['largeBatch'] ) && 'true' === $_REQUEST['largeBatch'] ) {
Expand All @@ -846,7 +846,7 @@ function ( $value ) {
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching -- Permission check requires direct lookup.
$batch_object = $wpdb->get_var( $wpdb->prepare( 'SELECT object FROM %i WHERE id = %d', $valid_table, $first_id ) );
if ( ! $batch_object ) {
wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) );
wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) );

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.

                wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );

}
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching -- Permission check requires direct lookup.
$affected_post_ids = $wpdb->get_col( $wpdb->prepare( 'SELECT DISTINCT postid FROM %i WHERE siteid = %d AND object = %s', $valid_table, $siteid, $batch_object ) );
Expand All @@ -858,7 +858,7 @@ function ( $value ) {
}

if ( empty( $affected_post_ids ) ) {
wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) );
wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) );

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.

            wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );

}

foreach ( $affected_post_ids as $affected_post_id ) {
Expand Down Expand Up @@ -902,7 +902,7 @@ function ( $value ) {
];

if ( ! $data ) {
wp_send_json_error( new \WP_Error( '-2', __( 'No ignore data to return', 'accessibility-checker' ) ) );
wp_send_json_error( new \WP_Error( '-2', __( 'No dismiss data to return', 'accessibility-checker' ) ) );

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'No dismiss data to return' is grammatically incorrect. Using the noun form 'dismissal' (i.e., 'No dismissal data to return') is grammatically correct and matches standard English usage.

            wp_send_json_error( new \WP_Error( '-2', __( 'No dismissal data to return', 'accessibility-checker' ) ) );

}
wp_send_json_success( wp_json_encode( $data ) );
}
Expand Down
4 changes: 2 additions & 2 deletions admin/site-health/class-pro.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ function ( $fix ) {
'value' => esc_html( get_option( 'edacp_simplified_summary_heading' ) ),
],
'ignore_permissions' => [
'label' => __( 'Ignore Permissions', 'accessibility-checker' ),
'label' => __( 'Dismiss Permissions', 'accessibility-checker' ),
'value' => esc_html( get_option( 'edacp_ignore_user_roles' ) ? implode( ', ', get_option( 'edacp_ignore_user_roles' ) ) : __( 'None', 'accessibility-checker' ) ),
],
'ignores_db_table_count' => [
'label' => __( 'Ignores DB Table Count', 'accessibility-checker' ),
'label' => __( 'Dismisses DB Table Count', 'accessibility-checker' ),

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'Dismisses DB Table Count' is grammatically incorrect because 'Dismisses' is a verb form. The plural noun form 'Dismissals' (i.e., 'Dismissals DB Table Count') should be used instead to match the original 'Ignores DB Table Count'.

                    'label' => __( 'Dismissals DB Table Count', 'accessibility-checker' ),

'value' => absint( edac_database_table_count( 'accessibility_checker_global_ignores' ) ),
],
'fixes' => [
Expand Down
6 changes: 3 additions & 3 deletions includes/options-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ function edac_register_setting() {

add_settings_field(
'edacp_ignore_user_roles',
__( 'Ignore Permissions', 'accessibility-checker' ),
__( 'Dismiss Permissions', 'accessibility-checker' ),

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Regenerate catalogs for renamed UI strings

When a bundled non-English locale is active, this renamed msgid (and the other renamed strings in this commit) is no longer translatable because the checked-in catalogs were not regenerated: languages/accessibility-checker.pot/.po still contain the old Ignore Permissions, No ignore data to return, Ignored, and %d Ignored entries, and the frontend-highlighter JSON still lacks the new Dismissed/%d Dismissed keys. Since WordPress looks up translations by the exact English msgid, these labels fall back to English after this change; please update the POT/PO/MO/JSON artifacts with the source changes.

Useful? React with 👍 / 👎.

'edac_ignore_user_roles_cb',
'edac_settings',
'edac_permissions',
Expand Down Expand Up @@ -682,7 +682,7 @@ function edac_post_types_cb() {
<?php } else { ?>
<p class="edac-description">
<?php
esc_html_e( 'Choose which post types should be checked during a scan. Please note, removing a previously selected post type will remove its scanned information and any custom ignored warnings that have been setup.', 'accessibility-checker' );
esc_html_e( 'Choose which post types should be checked during a scan. Please note, removing a previously selected post type will remove its scanned information and any custom dismissed warnings that have been setup.', 'accessibility-checker' );
?>
</p>
<?php
Expand Down Expand Up @@ -1000,7 +1000,7 @@ function edac_ignore_user_roles_cb() {
<?php endif; ?>
</fieldset>
<p class="edac-description">
<?php esc_html_e( 'Choose which user roles have permission to ignore issues.', 'accessibility-checker' ); ?>
<?php esc_html_e( 'Choose which user roles have permission to dismiss issues.', 'accessibility-checker' ); ?>
</p>
<?php
}
Expand Down
6 changes: 3 additions & 3 deletions src/frontendHighlighterApp/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,7 +1211,7 @@ class AccessibilityCheckerHighlight {
const typeIconUri = typeIconDataUris[ matchingObj.rule_type ];
const typeBadgeHtml = `<span class="edac-badge edac-badge--${ matchingObj.rule_type } edac-badge--large">
${ typeIconUri ? `<img src="${ typeIconUri }" width="16" height="16" style="display:block;width:16px;height:16px;flex-shrink:0" alt="" />` : '' }
<span class="edac-badge__label">${ { error: __( 'Problem', 'accessibility-checker' ), warning: __( 'Needs Review', 'accessibility-checker' ), ignored: __( 'Ignored', 'accessibility-checker' ) }[ matchingObj.rule_type ] ?? matchingObj.rule_type }</span>
<span class="edac-badge__label">${ { error: __( 'Problem', 'accessibility-checker' ), warning: __( 'Needs Review', 'accessibility-checker' ), ignored: __( 'Dismissed', 'accessibility-checker' ) }[ matchingObj.rule_type ] ?? matchingObj.rule_type }</span>
</span>`;

content += `</div>`;
Expand Down Expand Up @@ -1619,8 +1619,8 @@ class AccessibilityCheckerHighlight {
const breakdownParts = [ problemsLabel, reviewLabel ];
if ( ignoredCount > 0 ) {
breakdownParts.push( sprintf(
// translators: %d is the number of ignored issues.
_n( '%d Ignored', '%d Ignored', ignoredCount, 'accessibility-checker' ),
// translators: %d is the number of dismissed issues.
_n( '%d Dismissed', '%d Dismissed', ignoredCount, 'accessibility-checker' ),
ignoredCount
) );
}
Expand Down
Loading