Skip to content

chore: improve punctuation and spacing of errors#1456

Merged
tj098895 merged 2 commits intomainfrom
chore/improve-error-messages
Mar 25, 2026
Merged

chore: improve punctuation and spacing of errors#1456
tj098895 merged 2 commits intomainfrom
chore/improve-error-messages

Conversation

@Aleksander-Karlsson
Copy link
Copy Markdown
Contributor

@Aleksander-Karlsson Aleksander-Karlsson commented Mar 25, 2026

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

Encountered this message during the course, it's missing whitespaces between some words.
Screenshot 2026-03-25 at 10 06 27

I also notices some inconsistencies in punctuation in this file, I guess that is a problem larger than this file but I only added periods here 🤷

What else did you consider?

Between the lines?

@Aleksander-Karlsson Aleksander-Karlsson requested a review from a team as a code owner March 25, 2026 09:11
@tj098895 tj098895 merged commit 30b2b43 into main Mar 25, 2026
24 checks passed
@tj098895 tj098895 deleted the chore/improve-error-messages branch March 25, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants