Skip to content

chore: improve punctuation and spacing of errors #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tj098895 merged 2 commits into from
Mar 25, 2026
Merged

chore: improve punctuation and spacing of errors #1456

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37dc38f
chore: improve punctuation and spacing of errors
Aleksander-Karlsson Mar 25, 2026
643a493
chore: use the str values of keywords for errmsg
Aleksander-Karlsson Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/libecalc/presentation/yaml/mappers/consumer_function_mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def _get_resource(self, resource_name: str, reference: str) -> Resource:
raise ModelValidationException(
errors=[
self._create_error(
message=f"Unable to find resource '{resource_name}'", reference=reference, key="FILE"
message=f"Unable to find resource '{resource_name}'.", reference=reference, key="FILE"
)
]
)
Expand Down Expand Up @@ -428,7 +428,7 @@ def _create_variable_speed_compressor_train(
)
pressure_control = _pressure_control_mapper(model)
if fluid_model is None:
raise DomainValidationException("Fluid model is required for compressor train")
raise DomainValidationException("Fluid model is required for compressor train.")

compressor_model = CompressorTrainCommonShaft(
stages=stages,
Expand Down Expand Up @@ -476,13 +476,13 @@ def _create_single_speed_compressor_train(
maximum_discharge_pressure = model.maximum_discharge_pressure
if maximum_discharge_pressure and pressure_control != FixedSpeedPressureControl.DOWNSTREAM_CHOKE:
raise DomainValidationException(
f"Setting maximum discharge pressure for single speed compressor train is currently"
f"only supported with {FixedSpeedPressureControl.DOWNSTREAM_CHOKE} pressure control"
f"option. Pressure control option is {pressure_control}"
f"Setting {EcalcYamlKeywords.maximum_discharge_pressure} for single speed compressor train is currently "
f"only supported with {FixedSpeedPressureControl.DOWNSTREAM_CHOKE.value} pressure control option. "
f"Pressure control option is {pressure_control.value}."
)

if fluid_model is None:
raise DomainValidationException("Fluid model is required for compressor train")
raise DomainValidationException("Fluid model is required for compressor train.")

compressor_model = CompressorTrainCommonShaft(
stages=stages,
Expand Down Expand Up @@ -556,7 +556,7 @@ def _create_simplified_model_with_prepared_stages(
# For unknown stages, maximum_pressure_ratio_per_stage is required to determine stage count
if train_spec.maximum_pressure_ratio_per_stage is None:
raise DomainValidationException(
"MAXIMUM_PRESSURE_RATIO_PER_STAGE is required for unknown compressor stages"
"MAXIMUM_PRESSURE_RATIO_PER_STAGE is required for unknown compressor stages."
)

suction_pressure = operational_data.suction_pressures
Expand Down Expand Up @@ -762,7 +762,7 @@ def _create_variable_speed_compressor_train_multiple_streams_and_pressures(
]

if not any(fluid_models):
raise DomainValidationException("An inlet stream is required for this model")
raise DomainValidationException("An inlet stream is required for this model.")

interstage_pressures = {i for i, stage in enumerate(stages) if stage.has_control_pressure}
stage_number_interstage_pressure = interstage_pressures.pop() if interstage_pressures else None
Expand Down Expand Up @@ -875,7 +875,7 @@ def _get_resource(self, resource_name: str, reference: str) -> Resource:
raise ModelValidationException(
errors=[
self._create_error(
message=f"Unable to find resource '{resource_name}'", reference=reference, key="FILE"
message=f"Unable to find resource '{resource_name}'.", reference=reference, key="FILE"
)
]
)
Expand Down Expand Up @@ -928,7 +928,7 @@ def _get_resource(self, resource_name: str, reference: str) -> Resource:
raise ModelValidationException(
errors=[
self._create_error(
message=f"Unable to find resource '{resource_name}'", reference=reference, key="FILE"
message=f"Unable to find resource '{resource_name}'.", reference=reference, key="FILE"
)
]
)
Expand Down
Loading