Skip to content

Fix delete feature of auto scheduling#2053

Merged
Eddasol merged 1 commit intoequinor:mainfrom
Eddasol:autoSchedululeDelete
Mar 4, 2025
Merged

Fix delete feature of auto scheduling#2053
Eddasol merged 1 commit intoequinor:mainfrom
Eddasol:autoSchedululeDelete

Conversation

@Eddasol
Copy link
Copy Markdown
Contributor

@Eddasol Eddasol commented Mar 3, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 3, 2025

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@Eddasol Eddasol force-pushed the autoSchedululeDelete branch 2 times, most recently from 112c9dc to ff2a3f8 Compare March 4, 2025 07:06
@github-actions github-actions bot added the database-change Will require migration label Mar 4, 2025
@Eddasol Eddasol changed the title WIP: Fix delete feature of auto scheduling Fix delete feature of auto scheduling Mar 4, 2025
@Eddasol Eddasol marked this pull request as ready for review March 4, 2025 07:13
@Eddasol Eddasol requested a review from Christdej March 4, 2025 07:29
@Eddasol Eddasol linked an issue Mar 4, 2025 that may be closed by this pull request
Cannot remove auto scheduling #2052
Closed
@Eddasol Eddasol force-pushed the autoSchedululeDelete branch from ff2a3f8 to 8d6622d Compare March 4, 2025 09:06
@Eddasol Eddasol force-pushed the autoSchedululeDelete branch from 8d6622d to 2e1b731 Compare March 4, 2025 09:08
@equinor equinor deleted a comment from github-actions bot Mar 4, 2025
Christdej
Christdej approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 3a04864 into equinor:main Mar 4, 2025
13 checks passed
@Eddasol Eddasol deleted the autoSchedululeDelete branch March 4, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

No one assigned

Labels

database-change Will require migration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot remove auto scheduling

2 participants

@Eddasol @Christdej