ENH: Use Masterdata model from fmu-datamodels - #38
Merged
Conversation
joargr
approved these changes
Aug 13, 2025
joargr
left a comment
joargr
left a comment
Contributor
There was a problem hiding this comment.
I haven't tried running the code, but it looks ok.
tnatt
force-pushed
the
masterdata-from-fmu-datamodels
branch
from
August 13, 2025 13:58
5a3fa39 to
05a7e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #34
PR to use the
Masterdatamodel fromfmu-datamodelsinstead.Note the
smdafield in theMasterdatamodel is non-optional, hence the change to set themasterdatafield in the project config optional instead.Checklist
--cov=src/ --cov-report term-missing)