Skip to content

Mqtt refactor - #1164

Open
andchiind wants to merge 8 commits into
equinor:mainfrom
andchiind:mqtt-refactor
Open

Mqtt refactor#1164
andchiind wants to merge 8 commits into
equinor:mainfrom
andchiind:mqtt-refactor

Conversation

@andchiind

@andchiind andchiind commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Closes #1163

Previously all telemetry thread logic was done within each isar implementation. This PR moves the responsibility to ISAR, reducing the overall complexity in the robot interface, whilst providing greater control/error handling within the telemetry threads. In some cases the telemetry thread functionality was hackily used to implement general long lived threads for other purposes in ISAR instances. For this purpose I have instead created a new robot interface function for starting generic threads.

There are several commits that change the robot interface, but the hope is that all commits in this PR will be included in a single ISAR release so that we only need to update the ISAR implementations once.

See:

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@andchiind andchiind self-assigned this Aug 18, 2026
@andchiind andchiind added breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality labels Aug 18, 2026
@andchiind
andchiind force-pushed the mqtt-refactor branch 6 times, most recently from 4e00400 to ab0829d Compare August 19, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change A breaking change which introduces changes to the public APIs improvement Improvement to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor MqttPublisher

1 participant