Mqtt refactor - #1164
Open
andchiind wants to merge 8 commits into
Open
Conversation
andchiind
force-pushed
the
mqtt-refactor
branch
from
August 18, 2026 11:14
c9c8f99 to
e1ff62a
Compare
andchiind
force-pushed
the
mqtt-refactor
branch
from
August 18, 2026 11:17
e1ff62a to
129be47
Compare
andchiind
force-pushed
the
mqtt-refactor
branch
6 times, most recently
from
August 19, 2026 11:45
4e00400 to
ab0829d
Compare
andchiind
force-pushed
the
mqtt-refactor
branch
from
August 19, 2026 11:54
ab0829d to
0554631
Compare
andchiind
marked this pull request as ready for review
August 19, 2026 12:15
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1163
Previously all telemetry thread logic was done within each isar implementation. This PR moves the responsibility to ISAR, reducing the overall complexity in the robot interface, whilst providing greater control/error handling within the telemetry threads. In some cases the telemetry thread functionality was hackily used to implement general long lived threads for other purposes in ISAR instances. For this purpose I have instead created a new robot interface function for starting generic threads.
There are several commits that change the robot interface, but the hope is that all commits in this PR will be included in a single ISAR release so that we only need to update the ISAR implementations once.
See:
Ready for review checklist: