Suppress cppcheck exceptions #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achaikou
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Currently cppcheck already passes on main, while it does not pass on your local machine.
We suspect this is due to clang compiler being used? So can the first commit in this PR change our CI such that errors you bypass are reproducible there?
Also: current suppressions in the code mostly have explanations to them as to why they are suppressed, not fixed. Could we do the same?
yngve793
force-pushed
the
fix/ccpcheck_old_code
branch
from
e4a0ffe to
e75ab51
Compare
yngve793
commented
Mar 26, 2025
yngve793
force-pushed
the
fix/ccpcheck_old_code
branch
2 times, most recently
from
9ed7f65 to
007c75b
Compare
achaikou
reviewed
Mar 27, 2025
yngve793
force-pushed
the
fix/ccpcheck_old_code
branch
from
007c75b to
b500a83
Compare
yngve793
commented
Mar 28, 2025
achaikou
approved these changes
Apr 9, 2025
yngve793
force-pushed
the
fix/ccpcheck_old_code
branch
from
b500a83 to
6ad9ad0
Compare
yngve793
force-pushed
the
fix/ccpcheck_old_code
branch
from
6ad9ad0 to
13f0be1
Compare
achaikou
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective is to run cppcheck during rebase testing. Adding suppress comments such that the codebase can pass without error or warning flags being raised.