Suppress cppcheck exceptions

[yngve793]

The objective is to run cppcheck during rebase testing. Adding suppress comments such that the codebase can pass without error or warning flags being raised.

[achaikou]

Currently cppcheck already passes on main, while it does not pass on your local machine.
We suspect this is due to clang compiler being used? So can the first commit in this PR change our CI such that errors you bypass are reproducible there?

Also: current suppressions in the code mostly have explanations to them as to why they are suppressed, not fixed. Could we do the same?

[yngve793]

Added a commit with job that runs analyzers on mac. It is not clear how to fix the issues.

[achaikou]

Good. Now I see what has failed. We actually can fix most of them!

[achaikou]

You have to turn on testing if you want it enabled for testing locally too.

That would lead to fixing few more errors that you don't get, but CI does

lib/test/matchers.hpp:49:25: warning: The struct 'ApproxRange' defines member function with name 'from' also defined in its parent class 'SimilarRange < float >'. [duplInheritedMember]
   static SimilarRange from(const std::vector< U >& ) = delete;
                       ^
lib/test/matchers.hpp:31:25: note: Parent function 'SimilarRange < float >::from'
   static SimilarRange from(const std::vector< U >& xs) {
                       ^
lib/test/matchers.hpp:49:25: note: Derived function 'ApproxRange::from'
   static SimilarRange from(const std::vector< U >& ) = delete;

This one must be suppressed, from what I see

    // cppcheck-suppress duplInheritedMember
    static SimilarRange from(const std::vector< U >& ) = delete;

 lib/test/segy.cpp:1579:5: warning: Member variable 'int24_base::bytes' is not initialized in the constructor. [uninitMemberVar]
    int24_base() = default;

Need to explicitly initialize all to zero
int24_base() : bytes{0, 0, 0} {}

 lib/test/segy.cpp:1587:28: style: C-style pointer casting [cstyleCast]
        this->bytes[0] = ((const char*)&x)[0];

I think that can be fixed with

#if HOST_LSB
        std::memcpy(&this->bytes[0], &x, 2);
        this->bytes[2] = sign;
#else
        this->bytes[0] = sign;
        std::memcpy(&this->bytes[1], &x, 2);
#endif

[achaikou]

So do you want to enable cppcheck for tests here or not?

I am fine with both, it is just if you want to use them locally and we won't have them on CI, you might get errors after someone else merges their PR.

[yngve793]

Updated analyzers workflow as suggested.
Added code suggestions to remove mac cpp-checks.