Suppress cppcheck exceptions

.github/workflows/analyzers.yaml

@@ -9,14 +9,22 @@ on:
 
 jobs:
   cppcheck:
-    runs-on: ubuntu-latest
+    name: cppcheck on ${{ matrix.os }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - os: ubuntu-latest
+            cppcheck_install_command: sudo apt-get update && sudo DEBIAN_FRONTEND=noninteractive apt-get -y install cppcheck
+          - os: macos-latest
+            cppcheck_install_command: brew install cppcheck
     steps:
       - uses: actions/checkout@v4
 
       - name: Install dependencies
         run: |
-          sudo apt-get update
-          sudo DEBIAN_FRONTEND=noninteractive apt-get -y install cppcheck
+          ${{ matrix.cppcheck_install_command }}
 
       - name: Configure
         run: |
@@ -34,8 +42,9 @@ jobs:
             --suppressions-list=cppcheck/suppressions.txt   \
             --inline-suppr                                  \
             --project=build/compile_commands.json           \
-            --error-exitcode=1
-
+            --error-exitcode=1                              \
+            --check-level=exhaustive
+
   scan_build:
     runs-on: ubuntu-latest
     steps:

lib/experimental/segyio/segyio.hpp

@@ -426,6 +426,7 @@ class basic_file : public Traits< basic_file< Traits... > >... {
     explicit
     basic_file( const segyio::path& path,
                 const segyio::config& cfg = config() ) noexcept(false)
+    // cppcheck-suppress internalAstError
     : Traits< basic_file >( {} ) ... {
 
         this->consider( path );

lib/include/segyio/segy.h

@@ -633,6 +633,7 @@ typedef enum {
     SEGY_MMAP_INVALID,
     SEGY_READONLY,
     SEGY_NOTFOUND,
+    SEGY_MEMORY_ERROR,
 } SEGY_ERROR;
 
 #ifdef __cplusplus

lib/src/segy.c

@@ -821,7 +821,7 @@ static int memread( void* dest, const segy_file* fp, const void* src, size_t n )
     return SEGY_OK;
 }
 
-static int memwrite( segy_file* fp, void* dest, const void* src, size_t n ) {
+static int memwrite( const segy_file* fp, void* dest, const void* src, size_t n ) {
     const void* begin = fp->addr;
     const void* end = (const char*)fp->addr + fp->fsize;
     const void* destend = (const char*)dest + n;
@@ -1897,6 +1897,7 @@ int segy_readsubtr( segy_file* fp,
      */
     void* tracebuf = rangebuf ? rangebuf : malloc( elems * elemsize );
 
+    if (!tracebuf) return SEGY_MEMORY_ERROR;
     const int readc = (int) fread( tracebuf, elemsize, elems, fp->fp );
     if( readc != elems ) {
         if( !rangebuf ) free( tracebuf );
@@ -2013,6 +2014,8 @@ int segy_writesubtr( segy_file* fp,
      */
     if( !fp->addr && (step == 1 || step == -1) && fp->lsb ) {
         void* tracebuf = rangebuf ? rangebuf : malloc( elems * elemsize );
+
+        if (!tracebuf) return SEGY_MEMORY_ERROR;
         memcpy( tracebuf, buf, elemsize * elems );
 
         if (step == -1) reverse(tracebuf, elems, elemsize);
@@ -2061,6 +2064,7 @@ int segy_writesubtr( segy_file* fp,
     void* tracebuf = rangebuf ? rangebuf : malloc( elems * elemsize );
 
     // like in readsubtr, read a larger chunk and then step through that
+    if (!tracebuf) return SEGY_MEMORY_ERROR;
     const int readc = (int) fread( tracebuf, elemsize, elems, fp->fp );
     if( readc != elems ) { free( tracebuf ); return SEGY_FREAD_ERROR; }
     /* rewind, because fread advances the file pointer */

lib/test/segy.cpp

@@ -6,6 +6,7 @@
 #include <limits>
 #include <vector>
 #include <array>
+#include <string.h>
 
 // disable conversion from 'const _Elem' to '_Objty' MSC warnings.
 // warnings reason is unknown, should be caused by Catch2 though, thus ignored
@@ -1576,21 +1577,19 @@ SCENARIO( "reading a large file", "[c.segy]" ) {
 struct int24_base {
     unsigned char bytes[3];
 
-    int24_base() = default;
+    int24_base() : bytes{0, 0, 0} {}
     // cppcheck-suppress noExplicitConstructor
     int24_base(const int16_t& x) {
         /* Sign is allowed to be negative even if type represents unsigned int,
          * which is done to keep behavior consistent with that of other formats
          */
         char sign = x < 0 ? -1 : 0;
 #if HOST_LSB
-        this->bytes[0] = ((const char*)&x)[0];
-        this->bytes[1] = ((const char*)&x)[1];
+        memcpy(&this->bytes[0], &x, 2);
         this->bytes[2] = sign;
 #else
         this->bytes[0] = sign;
-        this->bytes[1] = ((const char*)&x)[0];
-        this->bytes[2] = ((const char*)&x)[1];
+        memcpy(&this->bytes[1], &x, 2);
 #endif
     }
 
@@ -1762,14 +1761,18 @@ SCENARIO( "reading a 2-byte int file", "[c.segy][2-byte]" ) {
             CHECK( trace_bsize == 75 * 2 );
         }
 
-        WHEN( "the format is valid" ) THEN( "setting format succeeds" ) {
+        WHEN( "the format is valid" ) {
+            THEN( "setting format succeeds" ) {
                 Err err = segy_set_format( fp, format );
                 CHECK( err == Err::ok() );
+            }
         }
 
-        WHEN( "the format is invalid" ) THEN( "setting format fails" ) {
+        WHEN( "the format is invalid" ) {
+            THEN( "setting format fails" ) {
                 Err err = segy_set_format( fp, 50 );
                 CHECK( err == Err::args() );
+            }
         }
     }
 
@@ -1814,21 +1817,25 @@ SCENARIO( "reading a 2-byte int file", "[c.segy][2-byte]" ) {
             WHEN( "trace0 is after end-of-file" ) {
                 err = segy_traces( fp, &traces, 500000, trace_bsize );
 
-                THEN( "segy_traces fail" )
+                THEN( "segy_traces fail" ) {
                     CHECK( err == Err::args() );
+                }
 
-                THEN( "the input does not change" )
+                THEN( "the input does not change" ) {
                     CHECK( traces == 414 );
+                }
             }
 
             WHEN( "trace0 is negative" ) {
                 err = segy_traces( fp, &traces, -1, trace_bsize );
 
-                THEN( "segy_traces fail" )
+                THEN( "segy_traces fail" ) {
                     CHECK( err == Err::args() );
+                }
 
-                THEN( "the input does not change" )
+                THEN( "the input does not change" ) {
                     CHECK( traces == 414 );
+                }
             }
         }
     }