[Fix]: Create correct flow network per tree types, and make tree type selectable in front-end #1395
+976
−723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-end - Group tree dataframe model: create_df_for_tree_type, which separates sumo table data into correct dataframes per tree type. - Make end-point return network for each existing tree type. - Make Tree type a setting in front-end to being able to select.
- Remove usage if pa.Table in assembler, and utilize Polars Dataframe. Seems to be just as efficient. - Some linting/typing fixes - Fix unit test
jorgenherje
changed the title
Change form pa.Table to pl.Dataframe, convert from pa.Table -> pl.Dataframe in the FlowNetworkAssembler
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create flow network per tree type and provide to front-end for selection.
This PR fixes incorrect dataframe filtering in the Flow Network back-end and migrates the implementation from pandas/pyArrow to polars for better performance. The front-end now supports tree type selection for visualization.
Back-end Changes
_utils/folder for better structure_group_tree_dataframe_model.pyrenamed togroup_tree_dataframe_model.pyand placed in_utilsfolderFront-end Changes
Technical Details
group_tree_dataframe_model.pywith corrected filtering logic_utils/flow_network_assembler.pyto use polarsTODO:
lib/services/pyproject.tomlif [Back-end]: Replace pandas with polars #1402 is merged to main first.Closes: #1149