-
Notifications
You must be signed in to change notification settings - Fork 12
[Back-end]: Replace pandas with polars #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Summary vector statistics calc - Parameter utils - PVT converter
HansKallekleiv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Approved, with a few comments after reading up on Polars.
Probably not important as everything is fairly fast, but might be worth thinking about at some point.
I think we should try to avoid things like loops and lamdas when working with Polars, as it forces serializing between rust and python.
backend_py/libs/services/src/webviz_services/sumo_access/parameter_access.py
Outdated
Show resolved
Hide resolved
backend_py/libs/services/src/webviz_services/summary_vector_statistics.py
Outdated
Show resolved
Hide resolved
backend_py/libs/services/src/webviz_services/summary_vector_statistics.py
Outdated
Show resolved
Hide resolved
backend_py/libs/services/src/webviz_services/summary_vector_statistics.py
Outdated
Show resolved
Hide resolved
|
During testing of the statistics calculations I found deviation between results. Have to verify statistics calculations/aggregation for @sigurdp recalls that |
|
Further testing shows that when using Both polars and numpy aggregation is tested with input table with During testing, I got same results using Conclusion: |
Remove usage of Pandas and replace usage with Polars
Note this PR does not replace for flow network access+service layer. It is handled in the following PR: #1395
Replace
PandaswithPolarsin:TODO:
Polarscompared to old version withPandas+numpylib/services/pyproject.tomlif [Fix]: Create correct flow network per tree types, and make tree type selectable in front-end #1395 is merged to main first.Closes: #1401