Skip to content

Cover shell: true in e2e tests#2389

Merged
ericcornelissen merged 3 commits intomainfrom
e2e-test-shell-true
Mar 4, 2026
Merged

Cover shell: true in e2e tests#2389
ericcornelissen merged 3 commits intomainfrom
e2e-test-shell-true

Conversation

@ericcornelissen
Copy link
Copy Markdown
Owner

@ericcornelissen ericcornelissen commented Mar 4, 2026

No description provided.

@ericcornelissen ericcornelissen added the test Relates to testing label Mar 4, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Mar 4, 2026

DeepSource Code Review

We reviewed changes in 15f42c1...0f4eb4e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Mar 4, 2026 1:53p.m. Review ↗

because `/bin/sh` is not a (sym)link on macOS we can't know what shell
it is, so we can't test it.
@ericcornelissen

This comment was marked as resolved.

@coderabbitai

This comment was marked as spam.

@coderabbitai

This comment was marked as spam.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 739e065e-2136-4d98-8553-2c481768dac8

📥 Commits

Reviewing files that changed from the base of the PR and between 15f42c1 and 35c2521.

📒 Files selected for processing (1)
  • test/e2e/_common.js

Comment thread test/e2e/_common.js
@ericcornelissen

This comment was marked as resolved.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ericcornelissen ericcornelissen merged commit bccf14b into main Mar 4, 2026
42 checks passed
@ericcornelissen ericcornelissen deleted the e2e-test-shell-true branch March 4, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant