Skip to content

Cover shell: true in e2e tests #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericcornelissen merged 3 commits into from
Mar 4, 2026
Merged

Cover shell: true in e2e tests #2389

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
713428a
Cover `shell: true` in e2e tests
ericcornelissen Mar 4, 2026
35c2521
Skip `shell: true` on macOS
ericcornelissen Mar 4, 2026
0f4eb4e
Avoid mutating `systemShells`
ericcornelissen Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/e2e/_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,9 @@ export function getTestShells() {
}
}

if (!constants.isMacOS) {
systemShells.push(true);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

return [false, ...systemShells];
}