Refactor lRegExp usage to receive regexes instead of strings#2446
Merged
ericcornelissen merged 7 commits intomainfrom Apr 4, 2026
Merged
Refactor lRegExp usage to receive regexes instead of strings#2446ericcornelissen merged 7 commits intomainfrom
ericcornelissen merged 7 commits intomainfrom
Conversation
This is in order to ensure that `eslint-plugin-regexp` still validates
them.
Bump `@ericcornelissen/lregexp` to at least 1.0.7 because earlier
versions don't properly pass on flags from regular expression passed to
the constructor.
Disabled the `regexp/require-unicode-regexp` rule because the `u` flag
is incompatible with the `l` flag.
The `crs` regular expression was optimized based on feedback from
eslint-plugin-regexp:
/(?:(\r\n)|\r)/g can be optimized to /(\r\n)|\r/g
unicorn/better-regex
This commit only covers the `no-shell.js` files as a starting point and
proof of concept.
ericcornelissen
added
the
refactor
github-actions
bot
added
dependencies
This comment was marked as resolved.
This comment was marked as resolved.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2122, #2129, #2436, #2437