QA : extend test on eth_simulateV1 with test on historical and latest#20818
Draft
QA : extend test on eth_simulateV1 with test on historical and latest#20818
Conversation
Move blockHashOverrides map from inside simulateBlock to the SimulateV1 loop so that BLOCKHASH instructions in a simulated block can see the hashes of previously simulated blocks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Geth always sets SkipTransactionChecks=true for eth_simulateV1, meaning the EIP-7825 MaxTxnGasLimit cap never applies to simulated calls even in validation mode. Erigon was incorrectly setting CheckGas=validation, causing calls with gas > 16,777,216 to be rejected with ErrGasLimitTooHigh. The validation flag should only control nonce checking, not protocol-level transaction caps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #17330
Added more eth_simulateV1 tests "adapting" the Hive test suite.