Skip to content

QA : extend test on eth_simulateV1 with test on historical and latest #20818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lupin012 wants to merge 8 commits into
base: main
Choose a base branch
from
+5 −3
Draft

QA : extend test on eth_simulateV1 with test on historical and latest #20818

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17ceec4
extend test on eth_simulateV1 with test on historical and latest
lupin012 Apr 26, 2026
d9c25bc
update rpctest cache
lupin012 Apr 26, 2026
6970c8a
Merge branch 'main' into lupin012/extendTestsOnEthSimulateV1
lupin012 Apr 26, 2026
297fab0
Merge branch 'main' into lupin012/extendTestsOnEthSimulateV1
lupin012 Apr 26, 2026
e60e28e
rpc/jsonrpc: fix BLOCKHASH across simulated blocks in eth_simulateV1
lupin012 Apr 26, 2026
40818db
update to temp branch
lupin012 Apr 26, 2026
32a5936
rpc/jsonrpc: do not apply EIP-7825 gas cap to eth_simulateV1 calls
lupin012 Apr 26, 2026
f7cee9b
Merge branch 'main' into lupin012/extendTestsOnEthSimulateV1
lupin012 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rpc/jsonrpc/eth_simulation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,13 @@ func (api *APIImpl) SimulateV1(ctx context.Context, req SimulationRequest, block

// Iterate over each given SimulatedBlock
parent := sim.base
blockHashOverrides := ethapi.BlockHashOverrides{}
for index, bsc := range simulatedBlocks {
blockResult, current, err := sim.simulateBlock(ctx, tx, sharedDomains, &bsc, headers[index], parent, headers[:index], blockNumber == latestBlockNumber)
blockResult, current, err := sim.simulateBlock(ctx, tx, sharedDomains, &bsc, headers[index], parent, headers[:index], blockNumber == latestBlockNumber, blockHashOverrides)
if err != nil {
return nil, err
}
blockHashOverrides[current.NumberU64()] = current.Hash()
simulatedBlockResults = append(simulatedBlockResults, blockResult)
headers[index] = current.Header()
parent = current.Header()
Expand Down Expand Up @@ -507,6 +509,7 @@ func (s *simulator) simulateBlock(
parent *types.Header,
ancestors []*types.Header,
latest bool,
blockHashOverrides ethapi.BlockHashOverrides,
) (SimulatedBlockResult, *types.Block, error) {
header.ParentHash = parent.Hash()
if s.chainConfig.IsLondon(header.Number.Uint64()) {
Expand All @@ -529,7 +532,6 @@ func (s *simulator) simulateBlock(

blockNumber := header.Number.Uint64()

blockHashOverrides := ethapi.BlockHashOverrides{}
txnList := make([]types.Transaction, 0, len(bsc.Calls))
receiptList := make(types.Receipts, 0, len(bsc.Calls))
tracer := rpchelper.NewLogTracer(s.traceTransfers, blockNumber, common.Hash{}, common.Hash{}, 0)
Expand Down Expand Up @@ -788,7 +790,7 @@ func (s *simulator) simulateCall(
if err != nil {
return nil, nil, nil, err
}
msg.SetCheckGas(s.validation)
msg.SetCheckGas(false) // EIP-7825 gas cap does not apply to simulated calls (matches Geth SkipTransactionChecks)
msg.SetCheckNonce(s.validation)
txCtx := protocol.NewEVMTxContext(msg)
txn, err := call.ToTransaction(s.gasPool.Gas(), &blockCtx.BaseFee)
Expand Down
Loading