Release v1.19.1 - #418
Merged
Merged
Conversation
The review failed on the v1.19.0 release PR with 20 permission denials and "Reached maximum number of turns (40)". Two causes, both fixed. Release PRs are the wrong thing to review. A dev -> main PR aggregates commits that were each already reviewed on their own PR, so re-reviewing the whole release adds nothing - and the diff is large enough to reliably exhaust the turn budget, which then puts a red X on the release itself. Now skipped. The allowlist was still too narrow. --allowedTools REPLACES the default tool set rather than adding to it, so anything omitted is denied at runtime - and a denied call still consumes a turn. A short list therefore burns the budget and the review dies having posted nothing, which is how both #399 (10 denials) and this one (20) failed. Added the ordinary read-only exploration tools plus TodoWrite, and raised the cap to 60. Everything on the list is read-only except the two comment-posting tools. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…se-prs Skip review on release PRs; widen the reviewer tool allowlist
The Windows clipboard is a shared resource; when another process holds it, SetTextAsync throws CLIPBRD_E_CANT_OPEN, and an unguarded await in an async void handler crashes the app (issue #415, Robot Advice Copy to Clipboard). - New ClipboardHelper: all reads/writes retry briefly and never throw - Convert all 15 write sites and both paste sites in PlanViewer.App - Replace DataGrid's built-in Ctrl+C (unguarded inside Avalonia) with a guarded copy on all four grids, mirroring its exact key/modifier gate - Intercept TextBox Copy/Cut/Paste app-wide via class handlers; Avalonia's own implementations are unguarded async void / TimeoutException-only - Cut (editor and TextBoxes) only deletes the selection after the text actually reached the clipboard - Clipboard-busy feedback on Advice window, Copy Repro, and MCP copy button - Log AppDomain/TaskScheduler unhandled exceptions to LocalApplicationData\PerformanceStudio\crash.log Fixes #415 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ening Harden all clipboard paths against a busy Windows clipboard
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Bump version to 1.19.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
devtomainfor the v1.19.1 release.1.19.1 contents:
Verified: clean Release build (0 warnings), 288/288 tests, release-auditor gate passed.
No server/PlanShare changes — no manual deploy needed. Merging this PR fires
release.yml, which signs and publishes the v1.19.1 GitHub release (VSIX, Velopack win packages, macOS zips).🤖 Generated with Claude Code