Skip to content

docs(phase-4a): record executed archival of both standalone mirrors - #424

Merged
solomonneas merged 1 commit into
mainfrom
docs/phase-4b-executed
Jul 21, 2026
Merged

docs(phase-4a): record executed archival of both standalone mirrors#424
solomonneas merged 1 commit into
mainfrom
docs/phase-4b-executed

Conversation

@solomonneas

@solomonneas solomonneas commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Ticks the executed Phase 4B checklist items: migration notices landed as ordinary commits (graphtrail PR #44, miseledger PR #44), both mirror master branches ancestry-verified as never rewritten or force-pushed, and both repositories archived on GitHub on 2026-07-21. The product/documentation-link item stays open honestly. Contract test updated to lock the executed state.

Verification: contract test + vale green through brigade work verify run.

Summary by CodeRabbit

  • Tests
    • Updated compatibility and archive policy checklist validation to reflect newly completed items.
    • Added verification for the recorded archive dates of designated projects.
    • Adjusted expected totals for completed and pending checklist items.

Migration notices merged as ordinary commits (graphtrail #44, miseledger
#44), both master branches ancestry-verified unrewritten, and both
repositories archived on GitHub on 2026-07-21. One checklist item stays
open: product and documentation link updates to the Brigade release path.
@solomonneas solomonneas added the coderabbit-review Request one CodeRabbit review after CI is green label Jul 21, 2026
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e79349fb-ff5f-4a9a-ab4c-f3b37643bf48

📥 Commits

Reviewing files that changed from the base of the PR and between 7a13bce and 0b9d796.

⛔ Files ignored due to path filters (1)
  • docs/phase-4a-compatibility-and-archive.md is excluded by !docs/**, !**/docs/**
📒 Files selected for processing (1)
  • tests/test_release_metadata.py

📝 Walkthrough

Walkthrough

The Phase 4A release metadata test now expects updated checklist completion states, archived project entries with dates, and matching checked and unchecked item counts.

Changes

Phase 4A checklist

Layer / File(s) Summary
Update checklist expectations
tests/test_release_metadata.py
The test now expects completed checklist items for archiving graphtrail and miseledger, records their archive dates, and adjusts aggregate checklist counts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: recording the archival of both standalone mirrors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/phase-4b-executed

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 21, 2026
@solomonneas

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@solomonneas
solomonneas merged commit 980834d into main Jul 21, 2026
26 checks passed
@solomonneas
solomonneas deleted the docs/phase-4b-executed branch July 21, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coderabbit-review Request one CodeRabbit review after CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant