Skip to content

fix(evidence-ledger): stop writing unused config - #538

Merged
solomonneas merged 1 commit into
mainfrom
t3code/fix-miseledger-config-path
Jul 26, 2026
Merged

fix(evidence-ledger): stop writing unused config#538
solomonneas merged 1 commit into
mainfrom
t3code/fix-miseledger-config-path

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Closes #528.

Summary

  • Stop miseledger init from creating config.toml with unsupported db_path and cache_dir settings.
  • Preserve existing user-created config files without modifying them.
  • Add regression coverage for fresh initialization and existing config files.

Root cause

ResolvePaths derives runtime paths from the XDG environment. Nothing parses the config file written by init, so editing db_path appeared successful while imports continued writing to the default database.

Impact

Fresh initialization no longer advertises settings that MiseLedger ignores. Existing config files remain untouched and continue to have no effect on runtime path selection.

Verification

  • PATH=/usr/local/go/bin:$PATH go test -race ./...
  • ./scripts/verify (4220 passed, 3 skipped)

Co-Authored-By: Codex <codex@openai.com>
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 61bce696-b0d5-45d7-ab6a-b355961263c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/fix-miseledger-config-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@solomonneas solomonneas self-assigned this Jul 26, 2026
@solomonneas
solomonneas merged commit bd0ce0d into main Jul 26, 2026
28 checks passed
@solomonneas
solomonneas deleted the t3code/fix-miseledger-config-path branch July 26, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

evidence-ledger: init writes db_path into a config file nothing reads, silently misdirecting fork/diff

1 participant